You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/02/11 20:05:55 UTC
[GitHub] [druid] capistrant commented on a change in pull request #10880: add druid jdbc handler config for minimum number of rows per frame
capistrant commented on a change in pull request #10880:
URL: https://github.com/apache/druid/pull/10880#discussion_r574792233
##########
File path: sql/src/test/java/org/apache/druid/sql/avatica/DruidAvaticaHandlerTest.java
##########
@@ -918,6 +918,107 @@ public Frame fetch(
);
}
+
+ @Test
+ public void testMinRowsPerFrame() throws Exception
Review comment:
Trying to fully understand this test. Is this testing that if a client supplied rows per frame is less than the configured minimum rows per frame, we stick with the minimum in the config?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org