You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Chris Westin (JIRA)" <ji...@apache.org> on 2015/01/03 01:33:34 UTC
[jira] [Created] (DRILL-1925) inline static nested Accessor class
methods
Chris Westin created DRILL-1925:
-----------------------------------
Summary: inline static nested Accessor class methods
Key: DRILL-1925
URL: https://issues.apache.org/jira/browse/DRILL-1925
Project: Apache Drill
Issue Type: Improvement
Components: Execution - Codegen
Reporter: Chris Westin
Some scalar replacement opportunities had to be disabled because the holders' references are passed in to static methods on nested Accessor classes as out parameters (their members are filled in by the static methods). If we could inline those static methods (they generally just seem to be 5-10 lines), then those holders could be replaced.
I thought the best option here would be to run something based on BasicInterpreter but which would start a new interpreter for nested function calls, but which delegates to the containing interpreter to emit the code. But I'm not sure how hard this will be to set up -- it will require mapping through the transformations made to locals. And the interpreter calls are very broad, covering many instructions each.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)