You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/04/28 05:36:47 UTC
[kudu-CR] [fs] fix build on OS X
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6756
Change subject: [fs] fix build on OS X
......................................................................
[fs] fix build on OS X
Added kudu_fs dependency for kudu_fs_test_util library.
Prior to this patch, the following error was reported if trying to build
on OS X:
Undefined symbols for architecture x86_64:
"kudu::fs::LogBlockManager::kContainerDataFileSuffix", referenced from:
kudu::fs::LBMCorruptor::Init() in log_block_manager-test-util.cc.o
kudu::fs::LBMCorruptor::CreateIncompleteContainer()
in log_block_manager-test-util.cc.o
"kudu::fs::LogBlockManager::kContainerMetadataFileSuffix", referenced from:
kudu::fs::LBMCorruptor::Init() in log_block_manager-test-util.cc.o
kudu::fs::LBMCorruptor::CreateIncompleteContainer()
in log_block_manager-test-util.cc.o
"fLU64::FLAGS_log_container_max_size", referenced from:
kudu::fs::LBMCorruptor::Init() in log_block_manager-test-util.cc.o
"kudu::BlockId::CopyToPB(kudu::BlockIdPB*) const", referenced from:
kudu::fs::LBMCorruptor::AddMalformedRecordToContainer()
in log_block_manager-test-util.cc.o
kudu::fs::LBMCorruptor::AddMisalignedBlockToContainer()
in log_block_manager-test-util.cc.o
kudu::fs::LBMCorruptor::AddPartialRecordToContainer()
in log_block_manager-test-util.cc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/libkudu_fs_test_util.dylib] Error 1
Change-Id: I60e16871818bb8994a2ecc59628ba22633ece3ba
---
M src/kudu/fs/CMakeLists.txt
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/6756/1
--
To view, visit http://gerrit.cloudera.org:8080/6756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60e16871818bb8994a2ecc59628ba22633ece3ba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [fs] fix build on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [fs] fix build on OS X
......................................................................
[fs] fix build on OS X
Added kudu_fs dependency for kudu_fs_test_util library.
Prior to this patch, the following error was reported if trying to build
on OS X:
Undefined symbols for architecture x86_64:
"kudu::fs::LogBlockManager::kContainerDataFileSuffix", referenced from:
kudu::fs::LBMCorruptor::Init() in log_block_manager-test-util.cc.o
kudu::fs::LBMCorruptor::CreateIncompleteContainer()
in log_block_manager-test-util.cc.o
"kudu::fs::LogBlockManager::kContainerMetadataFileSuffix", referenced from:
kudu::fs::LBMCorruptor::Init() in log_block_manager-test-util.cc.o
kudu::fs::LBMCorruptor::CreateIncompleteContainer()
in log_block_manager-test-util.cc.o
"fLU64::FLAGS_log_container_max_size", referenced from:
kudu::fs::LBMCorruptor::Init() in log_block_manager-test-util.cc.o
"kudu::BlockId::CopyToPB(kudu::BlockIdPB*) const", referenced from:
kudu::fs::LBMCorruptor::AddMalformedRecordToContainer()
in log_block_manager-test-util.cc.o
kudu::fs::LBMCorruptor::AddMisalignedBlockToContainer()
in log_block_manager-test-util.cc.o
kudu::fs::LBMCorruptor::AddPartialRecordToContainer()
in log_block_manager-test-util.cc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/libkudu_fs_test_util.dylib] Error 1
Change-Id: I60e16871818bb8994a2ecc59628ba22633ece3ba
Reviewed-on: http://gerrit.cloudera.org:8080/6756
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/fs/CMakeLists.txt
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60e16871818bb8994a2ecc59628ba22633ece3ba
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
[kudu-CR] [fs] fix build on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [fs] fix build on OS X
......................................................................
Patch Set 1: Verified+1
Unrelated failure in RELEASE configuration:
22:37:01 > git fetch --tags --progress http://gerrit.cloudera.org/kudu refs/changes/56/6756/1
22:47:01 ERROR: Timeout after 10 minutes
I manually verified RELEASE config build at ve0518: success.
--
To view, visit http://gerrit.cloudera.org:8080/6756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60e16871818bb8994a2ecc59628ba22633ece3ba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [fs] fix build on OS X
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [fs] fix build on OS X
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60e16871818bb8994a2ecc59628ba22633ece3ba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No