[GitHub] [ignite] ololo3000 commented on a change in pull request #8266: IGNITE-13472 fix security context for JDBC bulkload operations

[GitBox <gi...@apache.org>]

ololo3000 commented on a change in pull request #8266:
URL: https://github.com/apache/ignite/pull/8266#discussion_r566009404



##########
File path: modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcAuthorizationTest.java
##########
@@ -164,7 +169,11 @@ public void testCopyFrom() throws Exception {
         assertAuthorizationFailed(sql, CACHE_READ_USER);
         assertAuthorizationFailed(sql, CACHE_REMOVE_USER);
 
+        int cnt = ignite(0).cache(DEFAULT_CACHE_NAME).size();

Review comment:
       It seems that we should check TEST_BULKLOAD_CACHE cache size here and check its size using equality.

##########
File path: modules/clients/src/test/java/org/apache/ignite/jdbc/JdbcAuthorizationTest.java
##########
@@ -143,7 +144,11 @@ public void testInsert() throws Exception {
         assertAuthorizationFailed(sql, CACHE_READ_USER);
         assertAuthorizationFailed(sql, CACHE_REMOVE_USER);
 
+        int cnt = ignite(0).cache(DEFAULT_CACHE_NAME).size();
+
         execute(sql, CACHE_PUT_USER);
+
+        assertTrue(ignite(0).cache(DEFAULT_CACHE_NAME).size() > cnt);

Review comment:
       Can we verify that the cache size has only increased by one?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org