You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/05/15 03:15:22 UTC
[GitHub] flink pull request #6014: [FLINK-8933] Avoid calling Class#newInstance
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6014
[FLINK-8933] Avoid calling Class#newInstance
## What is the purpose of the change
*This pull request refactored the usage of `Class#newInstance`*
## Brief change log
- *Replaced `Class#newInstance` to `Class#newInstance#getDeclaredConstructor#newInstance`*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
This change is already covered by existing tests*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / no / **don't know**)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8933
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6014.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6014
----
commit fa3e4dbb0f4adac31c3d30e67afd0d358def5e10
Author: yanghua <ya...@...>
Date: 2018-05-15T03:11:06Z
[FLINK-8933] Avoid calling Class#newInstance
----
---
[GitHub] flink pull request #6014: [FLINK-8933] Avoid calling Class#newInstance
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6014
---
[GitHub] flink issue #6014: [FLINK-8933] Avoid calling Class#newInstance
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6014
The discussion on the JIRA clearly came tot he conclusion to do this change in 2 commits. Please separate the PR.
---
[GitHub] flink issue #6014: [FLINK-8933] Avoid calling Class#newInstance
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6014
OK now closing this and create two new PRs...
---
[GitHub] flink issue #6014: [FLINK-8933] Avoid calling Class#newInstance
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6014
cc @StephanEwen & @zentol just one commit~
---