You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/04 14:27:00 UTC
[GitHub] [spark] yaooqinn opened a new pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
yaooqinn opened a new pull request #28728:
URL: https://github.com/apache/spark/pull/28728
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638920911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638971155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28728:
URL: https://github.com/apache/spark/pull/28728#discussion_r435325539
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateFormatterSuite.scala
##########
@@ -199,4 +197,8 @@ class DateFormatterSuite extends SparkFunSuite with SQLHelper {
// SparkUpgradeException here.
intercept[SparkUpgradeException](formatter.parse("02-29"))
}
+
+ override def checkFormatterCreation(pattern: String, isParsing: Boolean): Unit = {
Review comment:
can we move it to the beginning of this class? to avoid code conflict when we add new tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639066919
**[Test build #123536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123536/testReport)** for PR 28728 at commit [`ca79e03`](https://github.com/apache/spark/commit/ca79e0351cbb6eda3ade7c696f1b7e2dd4ea398b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638989196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28728:
URL: https://github.com/apache/spark/pull/28728#discussion_r435406205
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -126,7 +126,7 @@ object DateFormatter {
zoneId: ZoneId,
locale: Locale = defaultLocale,
legacyFormat: LegacyDateFormat = LENIENT_SIMPLE_DATE_FORMAT,
- isParsing: Boolean = true): DateFormatter = {
+ isParsing: Boolean): DateFormatter = {
Review comment:
shall we change back the parameter name? It's only needed in timestamp formatter now, to indicate the fractional formatter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638920180
**[Test build #123536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123536/testReport)** for PR 28728 at commit [`ca79e03`](https://github.com/apache/spark/commit/ca79e0351cbb6eda3ade7c696f1b7e2dd4ea398b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28728:
URL: https://github.com/apache/spark/pull/28728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639136125
**[Test build #123538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123538/testReport)** for PR 28728 at commit [`d7fc6d9`](https://github.com/apache/spark/commit/d7fc6d9db1244f681066415b14e798820fc6f61e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638886114
**[Test build #123534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123534/testReport)** for PR 28728 at commit [`c8ac3f0`](https://github.com/apache/spark/commit/c8ac3f0bf289ea21f8e159daa779ddc5d663a377).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638970227
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bart-samwel commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
bart-samwel commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639310500
@cloud-fan Yes, let's forbid the legacy week-based letters that were non-localized. We can keep the new format letters, those are new features then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28728:
URL: https://github.com/apache/spark/pull/28728#discussion_r435405771
##########
File path: docs/sql-ref-datetime-pattern.md
##########
@@ -36,11 +36,8 @@ Spark uses pattern letters in the following table for date and timestamp parsing
|**M/L**|month-of-year|month|7; 07; Jul; July|
|**d**|day-of-month|number(3)|28|
|**Q/q**|quarter-of-year|number/text|3; 03; Q3; 3rd quarter|
-|**Y**|week-based-year|year|1996; 96|
-|**w**|week-of-week-based-year|number(2)|27|
-|**W**|week-of-month|number(1)|4|
|**E**|day-of-week|text|Tue; Tuesday|
-|**u**|localized day-of-week|number/text|2; 02; Tue; Tuesday|
+|**e**|localized day-of-week|number/text|2; 02; Tue; Tuesday|
Review comment:
shall we forbid `e` as well? It's not supported in 2.4 either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639137018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638962556
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123534/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639067523
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638992217
**[Test build #123538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123538/testReport)** for PR 28728 at commit [`d7fc6d9`](https://github.com/apache/spark/commit/d7fc6d9db1244f681066415b14e798820fc6f61e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638962545
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638901603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639070674
**[Test build #123535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123535/testReport)** for PR 28728 at commit [`7b95d6c`](https://github.com/apache/spark/commit/7b95d6c6c2984dea95e899470eb83cebf1c3cc31).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638896336
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639329553
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639071798
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28728:
URL: https://github.com/apache/spark/pull/28728#discussion_r435324570
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -234,22 +234,22 @@ private object DateTimeFormatterHelper {
val formatter = DateTimeFormatter.ofPattern("LLL qqq", Locale.US)
formatter.format(LocalDate.of(2000, 1, 1)) == "1 1"
}
- final val unsupportedLetters = Set('A', 'c', 'e', 'n', 'N', 'p')
+ final val unsupportedLetters = Set('A', 'c', 'n', 'N', 'p', 'Y', 'W', 'w', 'u')
Review comment:
how about we add a new list `weekBasedLetters`? They deserve a dedicated error message, to suggest users using the SQL function `EXTRACT`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28728:
URL: https://github.com/apache/spark/pull/28728#discussion_r435410059
##########
File path: docs/sql-ref-datetime-pattern.md
##########
@@ -36,11 +36,8 @@ Spark uses pattern letters in the following table for date and timestamp parsing
|**M/L**|month-of-year|month|7; 07; Jul; July|
|**d**|day-of-month|number(3)|28|
|**Q/q**|quarter-of-year|number/text|3; 03; Q3; 3rd quarter|
-|**Y**|week-based-year|year|1996; 96|
-|**w**|week-of-week-based-year|number(2)|27|
-|**W**|week-of-month|number(1)|4|
|**E**|day-of-week|text|Tue; Tuesday|
-|**u**|localized day-of-week|number/text|2; 02; Tue; Tuesday|
+|**e**|localized day-of-week|number/text|2; 02; Tue; Tuesday|
Review comment:
Forgot to update the doc, thanks for reminding
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28728:
URL: https://github.com/apache/spark/pull/28728#discussion_r435325729
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimestampFormatterSuite.scala
##########
@@ -418,15 +417,7 @@ class TimestampFormatterSuite extends SparkFunSuite with SQLHelper with Matchers
assert(t5 === date(1970))
}
- test("explicitly forbidden datetime patterns") {
- // not support by the legacy one too
- Seq("QQQQQ", "qqqqq", "A", "c", "e", "n", "N", "p").foreach { pattern =>
- intercept[IllegalArgumentException](TimestampFormatter(pattern, UTC).format(0))
- }
- // supported by the legacy one, then we will suggest users with SparkUpgradeException
- Seq("GGGGG", "MMMMM", "LLLLL", "EEEEE", "uuuuu", "aa", "aaa", "y" * 11, "y" * 11)
- .foreach { pattern =>
- intercept[SparkUpgradeException](TimestampFormatter(pattern, UTC).format(0))
- }
+ override def checkFormatterCreation(pattern: String, isParsing: Boolean): Unit = {
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638900222
**[Test build #123535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123535/testReport)** for PR 28728 at commit [`7b95d6c`](https://github.com/apache/spark/commit/7b95d6c6c2984dea95e899470eb83cebf1c3cc31).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28728:
URL: https://github.com/apache/spark/pull/28728#discussion_r435409142
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -126,7 +126,7 @@ object DateFormatter {
zoneId: ZoneId,
locale: Locale = defaultLocale,
legacyFormat: LegacyDateFormat = LENIENT_SIMPLE_DATE_FORMAT,
- isParsing: Boolean = true): DateFormatter = {
+ isParsing: Boolean): DateFormatter = {
Review comment:
We still have `unsupportedLettersForParsing = Set('E', 'F', 'q', 'Q')`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638992217
**[Test build #123538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123538/testReport)** for PR 28728 at commit [`d7fc6d9`](https://github.com/apache/spark/commit/d7fc6d9db1244f681066415b14e798820fc6f61e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639137018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639067523
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639067532
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123536/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638900222
**[Test build #123535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123535/testReport)** for PR 28728 at commit [`7b95d6c`](https://github.com/apache/spark/commit/7b95d6c6c2984dea95e899470eb83cebf1c3cc31).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638962379
**[Test build #123534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123534/testReport)** for PR 28728 at commit [`c8ac3f0`](https://github.com/apache/spark/commit/c8ac3f0bf289ea21f8e159daa779ddc5d663a377).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639112128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638886787
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638962545
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639111050
**[Test build #123537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123537/testReport)** for PR 28728 at commit [`7671d96`](https://github.com/apache/spark/commit/7671d963215465dcc27dd69df966eba3bab2acea).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638989196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639016448
I'm fine with it, what do you think? @bart-samwel @maropu @MaxGekk @HyukjinKwon @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638886114
**[Test build #123534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123534/testReport)** for PR 28728 at commit [`c8ac3f0`](https://github.com/apache/spark/commit/c8ac3f0bf289ea21f8e159daa779ddc5d663a377).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639071798
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638920911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638896336
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638920180
**[Test build #123536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123536/testReport)** for PR 28728 at commit [`ca79e03`](https://github.com/apache/spark/commit/ca79e0351cbb6eda3ade7c696f1b7e2dd4ea398b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638901603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638970542
**[Test build #123537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123537/testReport)** for PR 28728 at commit [`7671d96`](https://github.com/apache/spark/commit/7671d963215465dcc27dd69df966eba3bab2acea).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638970542
**[Test build #123537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123537/testReport)** for PR 28728 at commit [`7671d96`](https://github.com/apache/spark/commit/7671d963215465dcc27dd69df966eba3bab2acea).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638971155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-638886787
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28728:
URL: https://github.com/apache/spark/pull/28728#issuecomment-639112128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org