You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "cshuo (via GitHub)" <gi...@apache.org> on 2025/07/31 08:10:09 UTC
[PR] [HUDI-9671] Spark reads should skip record with UPDATE_BEFORE operation [hudi]
cshuo opened a new pull request, #13658:
URL: https://github.com/apache/hudi/pull/13658
### Change Logs
Spark reads should skip record with UPDATE_BEFORE operation
### Impact
Ensure records with UPDATE_BEFORE operation are not read by spark snapshot scan
### Risk level (write none, low medium or high below)
low
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9671] Spark reads should skip record with UPDATE_BEFORE operation [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13658:
URL: https://github.com/apache/hudi/pull/13658#discussion_r2245040385
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/TestDataSourceReadWithDeletes.java:
##########
@@ -87,8 +88,9 @@ public void setUp() {
schema = new Schema.Parser().parse(jsonSchema);
}
- @Test
- public void test() throws Exception {
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
Review Comment:
We should also fix `HoodieWriteMergeHandle` to ignore the update befores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9671] Spark reads should skip record with UPDATE_BEFORE operation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13658:
URL: https://github.com/apache/hudi/pull/13658#issuecomment-3139959831
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e913180fb760811158241f385d407e661d9e096",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7397",
"triggerID" : "3e913180fb760811158241f385d407e661d9e096",
"triggerType" : "PUSH"
}, {
"hash" : "76deb9d748d76030cc27f91dbd1aa2a4e00bcfd1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "76deb9d748d76030cc27f91dbd1aa2a4e00bcfd1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e913180fb760811158241f385d407e661d9e096 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7397)
* 76deb9d748d76030cc27f91dbd1aa2a4e00bcfd1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9671] Spark reads should skip record with UPDATE_BEFORE operation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13658:
URL: https://github.com/apache/hudi/pull/13658#issuecomment-3139965873
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e913180fb760811158241f385d407e661d9e096",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7397",
"triggerID" : "3e913180fb760811158241f385d407e661d9e096",
"triggerType" : "PUSH"
}, {
"hash" : "76deb9d748d76030cc27f91dbd1aa2a4e00bcfd1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7401",
"triggerID" : "76deb9d748d76030cc27f91dbd1aa2a4e00bcfd1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e913180fb760811158241f385d407e661d9e096 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7397)
* 76deb9d748d76030cc27f91dbd1aa2a4e00bcfd1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7401)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9671] Spark reads should skip record with UPDATE_BEFORE operation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13658:
URL: https://github.com/apache/hudi/pull/13658#issuecomment-3139278610
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e913180fb760811158241f385d407e661d9e096",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7397",
"triggerID" : "3e913180fb760811158241f385d407e661d9e096",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e913180fb760811158241f385d407e661d9e096 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7397)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9671] Spark reads should skip record with UPDATE_BEFORE operation [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #13658:
URL: https://github.com/apache/hudi/pull/13658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9671] Spark reads should skip record with UPDATE_BEFORE operation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13658:
URL: https://github.com/apache/hudi/pull/13658#issuecomment-3138982641
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e913180fb760811158241f385d407e661d9e096",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7397",
"triggerID" : "3e913180fb760811158241f385d407e661d9e096",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e913180fb760811158241f385d407e661d9e096 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7397)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9671] Spark reads should skip record with UPDATE_BEFORE operation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13658:
URL: https://github.com/apache/hudi/pull/13658#issuecomment-3138976907
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e913180fb760811158241f385d407e661d9e096",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3e913180fb760811158241f385d407e661d9e096",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3e913180fb760811158241f385d407e661d9e096 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9671] Spark reads should skip record with UPDATE_BEFORE operation [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13658:
URL: https://github.com/apache/hudi/pull/13658#issuecomment-3140156755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3e913180fb760811158241f385d407e661d9e096",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7397",
"triggerID" : "3e913180fb760811158241f385d407e661d9e096",
"triggerType" : "PUSH"
}, {
"hash" : "76deb9d748d76030cc27f91dbd1aa2a4e00bcfd1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7401",
"triggerID" : "76deb9d748d76030cc27f91dbd1aa2a4e00bcfd1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76deb9d748d76030cc27f91dbd1aa2a4e00bcfd1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=7401)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9671] Spark reads should skip record with UPDATE_BEFORE operation [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13658:
URL: https://github.com/apache/hudi/pull/13658#discussion_r2245034135
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/TestDataSourceReadWithDeletes.java:
##########
@@ -87,8 +88,9 @@ public void setUp() {
schema = new Schema.Parser().parse(jsonSchema);
}
- @Test
- public void test() throws Exception {
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
Review Comment:
We can use `@EnumSource` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org