You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/03/17 03:05:53 UTC
Review Request 32145: SQOOP-2201 Sqoop2: Add possibility to read
Hadoop configuration files to HFDS connector
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32145/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2201
https://issues.apache.org/jira/browse/SQOOP-2201
Repository: sqoop-sqoop2
Description
-------
I've added ability to the HDFS connector to read Hadoop configuration files and and broke the dependency on mapreduce's execution engine.
Diffs
-----
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 8237e51
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java 0a95e07
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java cee0a91
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java 78fd60a
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java 991e6c9
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java fce7728
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java 146c3b1
connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3904856
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java ce6af6e
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 2ef971d
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java ac90eac
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java a21e4a1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 5552e04
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java f69f08c
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java f850777
test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java 83273f1
Diff: https://reviews.apache.org/r/32145/diff/
Testing
-------
I had to update existing integration test as the "reasonable" defaults weren't applicable to them.
Thanks,
Jarek Cecho
Re: Review Request 32145: SQOOP-2201 Sqoop2: Add possibility to read
Hadoop configuration files to HFDS connector
Posted by Qian Xu <qi...@intel.com>.
> On March 17, 2015, 10:38 a.m., Qian Xu wrote:
> > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java, line 34
> > <https://reviews.apache.org/r/32145/diff/1/?file=897165#file897165line34>
> >
> > Is it possible to created a jira and use constants for MAX_LENGTH? And I might be too concerned about the size maximum in general. According to Linux header, filename max length can be 255, path max length can be 4096 and uri length can be 2083.
>
> Jarek Cecho wrote:
> Would you feel comfortable to take this to separate standalone JIRA? I feel that we should think about that more broadly.
I've created SQOOP-2221 to track this.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32145/#review76700
-----------------------------------------------------------
On March 17, 2015, 12:25 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32145/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 12:25 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2201
> https://issues.apache.org/jira/browse/SQOOP-2201
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added ability to the HDFS connector to read Hadoop configuration files and and broke the dependency on mapreduce's execution engine.
>
>
> Diffs
> -----
>
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 8237e51
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java 0a95e07
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java cee0a91
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java 78fd60a
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java 991e6c9
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java fce7728
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/TestHdfsConnector.java PRE-CREATION
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java 146c3b1
> connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3904856
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java ce6af6e
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 2ef971d
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java ac90eac
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java a21e4a1
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 5552e04
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java 716de30
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java f69f08c
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java f850777
> test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java 83273f1
> test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 3823583
>
> Diff: https://reviews.apache.org/r/32145/diff/
>
>
> Testing
> -------
>
> I had to update existing integration test as the "reasonable" defaults weren't applicable to them.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 32145: SQOOP-2201 Sqoop2: Add possibility to read
Hadoop configuration files to HFDS connector
Posted by Jarek Cecho <ja...@apache.org>.
> On March 17, 2015, 2:38 a.m., Qian Xu wrote:
> > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java, line 55
> > <https://reviews.apache.org/r/32145/diff/1/?file=897164#file897164line55>
> >
> > Line 50 has check the confDir already.
Good point - copy&paste error.
> On March 17, 2015, 2:38 a.m., Qian Xu wrote:
> > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java, line 71
> > <https://reviews.apache.org/r/32145/diff/1/?file=897164#file897164line71>
> >
> > There will be an error message in log and there is no exception is thrown. So if a config file cannot be loaded, the MR job might not fail completely? Maybe use warning instead of error?
I'll use warning instead - at this point it's not really an error as this is not specific to MR job, but just to the HDFS configuration.
> On March 17, 2015, 2:38 a.m., Qian Xu wrote:
> > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java, line 34
> > <https://reviews.apache.org/r/32145/diff/1/?file=897165#file897165line34>
> >
> > Is it possible to created a jira and use constants for MAX_LENGTH? And I might be too concerned about the size maximum in general. According to Linux header, filename max length can be 255, path max length can be 4096 and uri length can be 2083.
Would you feel comfortable to take this to separate standalone JIRA? I feel that we should think about that more broadly.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32145/#review76700
-----------------------------------------------------------
On March 17, 2015, 4:17 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32145/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 4:17 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2201
> https://issues.apache.org/jira/browse/SQOOP-2201
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added ability to the HDFS connector to read Hadoop configuration files and and broke the dependency on mapreduce's execution engine.
>
>
> Diffs
> -----
>
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 8237e51
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java 0a95e07
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java cee0a91
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java 78fd60a
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java 991e6c9
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java fce7728
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/TestHdfsConnector.java PRE-CREATION
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java 146c3b1
> connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3904856
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java ce6af6e
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 2ef971d
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java ac90eac
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java a21e4a1
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 5552e04
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java 716de30
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java f69f08c
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java f850777
> test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java 83273f1
> test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 3823583
>
> Diff: https://reviews.apache.org/r/32145/diff/
>
>
> Testing
> -------
>
> I had to update existing integration test as the "reasonable" defaults weren't applicable to them.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 32145: SQOOP-2201 Sqoop2: Add possibility to read
Hadoop configuration files to HFDS connector
Posted by Qian Xu <qi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32145/#review76700
-----------------------------------------------------------
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
<https://reviews.apache.org/r/32145/#comment124329>
Line 50 has check the confDir already.
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
<https://reviews.apache.org/r/32145/#comment124331>
There will be an error message in log and there is no exception is thrown. So if a config file cannot be loaded, the MR job might not fail completely? Maybe use warning instead of error?
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java
<https://reviews.apache.org/r/32145/#comment124332>
Is it possible to created a jira and use constants for MAX_LENGTH? And I might be too concerned about the size maximum in general. According to Linux header, filename max length can be 255, path max length can be 4096 and uri length can be 2083.
- Qian Xu
On March 17, 2015, 10:05 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32145/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 10:05 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2201
> https://issues.apache.org/jira/browse/SQOOP-2201
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added ability to the HDFS connector to read Hadoop configuration files and and broke the dependency on mapreduce's execution engine.
>
>
> Diffs
> -----
>
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 8237e51
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java 0a95e07
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java cee0a91
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java 78fd60a
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java 991e6c9
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java fce7728
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java 146c3b1
> connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3904856
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java ce6af6e
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 2ef971d
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java ac90eac
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java a21e4a1
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 5552e04
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java f69f08c
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java f850777
> test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java 83273f1
>
> Diff: https://reviews.apache.org/r/32145/diff/
>
>
> Testing
> -------
>
> I had to update existing integration test as the "reasonable" defaults weren't applicable to them.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 32145: SQOOP-2201 Sqoop2: Add possibility to read
Hadoop configuration files to HFDS connector
Posted by Qian Xu <qi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32145/#review76710
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Xu
On March 17, 2015, 12:25 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32145/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 12:25 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2201
> https://issues.apache.org/jira/browse/SQOOP-2201
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've added ability to the HDFS connector to read Hadoop configuration files and and broke the dependency on mapreduce's execution engine.
>
>
> Diffs
> -----
>
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 8237e51
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java 0a95e07
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java cee0a91
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java 78fd60a
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java 991e6c9
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java fce7728
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/TestHdfsConnector.java PRE-CREATION
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java 146c3b1
> connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3904856
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java ce6af6e
> test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 2ef971d
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java ac90eac
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java a21e4a1
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 5552e04
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java 716de30
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java f69f08c
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java f850777
> test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java 83273f1
> test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 3823583
>
> Diff: https://reviews.apache.org/r/32145/diff/
>
>
> Testing
> -------
>
> I had to update existing integration test as the "reasonable" defaults weren't applicable to them.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 32145: SQOOP-2201 Sqoop2: Add possibility to read
Hadoop configuration files to HFDS connector
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32145/
-----------------------------------------------------------
(Updated March 17, 2015, 4:25 a.m.)
Review request for Sqoop.
Changes
-------
Incorporating Qian's feedback.
Bugs: SQOOP-2201
https://issues.apache.org/jira/browse/SQOOP-2201
Repository: sqoop-sqoop2
Description
-------
I've added ability to the HDFS connector to read Hadoop configuration files and and broke the dependency on mapreduce's execution engine.
Diffs (updated)
-----
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 8237e51
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java 0a95e07
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java cee0a91
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java 78fd60a
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java 991e6c9
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java fce7728
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/TestHdfsConnector.java PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java 146c3b1
connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3904856
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java ce6af6e
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 2ef971d
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java ac90eac
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java a21e4a1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 5552e04
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java 716de30
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java f69f08c
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java f850777
test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java 83273f1
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 3823583
Diff: https://reviews.apache.org/r/32145/diff/
Testing
-------
I had to update existing integration test as the "reasonable" defaults weren't applicable to them.
Thanks,
Jarek Cecho
Re: Review Request 32145: SQOOP-2201 Sqoop2: Add possibility to read
Hadoop configuration files to HFDS connector
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32145/
-----------------------------------------------------------
(Updated March 17, 2015, 4:17 a.m.)
Review request for Sqoop.
Changes
-------
Fixed few integration tests.
Bugs: SQOOP-2201
https://issues.apache.org/jira/browse/SQOOP-2201
Repository: sqoop-sqoop2
Description
-------
I've added ability to the HDFS connector to read Hadoop configuration files and and broke the dependency on mapreduce's execution engine.
Diffs (updated)
-----
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 8237e51
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java 0a95e07
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java cee0a91
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java 78fd60a
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java 991e6c9
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java fce7728
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/TestHdfsConnector.java PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java 146c3b1
connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3904856
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java ce6af6e
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java 2ef971d
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java ac90eac
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java a21e4a1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 5552e04
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java 716de30
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java f69f08c
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java f850777
test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java 83273f1
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java 3823583
Diff: https://reviews.apache.org/r/32145/diff/
Testing
-------
I had to update existing integration test as the "reasonable" defaults weren't applicable to them.
Thanks,
Jarek Cecho