svn commit: r920973 - /subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/RevisionRange.java

[hw...@apache.org]

Author: hwright
Date: Tue Mar  9 16:40:50 2010
New Revision: 920973

URL: http://svn.apache.org/viewvc?rev=920973&view=rev
Log:
JavaHL: Use generics in one more location, and ignore a warning.

* subversion/bindings/javahl/src/org/apache/subversion/javahl/RevisionRange.java
  (RevisionRange): Specify the type of the Comparable interface.
  (compareTo): Take a RevisionRange object, and remove a cast.
  (RevisionRange): Suppress a warning, since this function is called by
    the native code.

Modified:
    subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/RevisionRange.java

Modified: subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/RevisionRange.java
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/RevisionRange.java?rev=920973&r1=920972&r2=920973&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/RevisionRange.java (original)
+++ subversion/trunk/subversion/bindings/javahl/src/org/apache/subversion/javahl/RevisionRange.java Tue Mar  9 16:40:50 2010
@@ -28,7 +28,7 @@ package org.apache.subversion.javahl;
  *
  * @since 1.5
  */
-public class RevisionRange implements Comparable, java.io.Serializable
+public class RevisionRange implements Comparable<RevisionRange>, java.io.Serializable
 {
     // Update the serialVersionUID when there is a incompatible change
     // made to this class.  See any of the following, depending upon
@@ -45,6 +45,7 @@ public class RevisionRange implements Co
     /**
      * Creates a new instance.  Called by native library.
      */
+    @SuppressWarnings("unused")
     private RevisionRange(long from, long to)
     {
         this.from = Revision.getInstance(from);
@@ -184,12 +185,12 @@ public class RevisionRange implements Co
     /**
      * @param range The RevisionRange to compare this object to.
      */
-    public int compareTo(Object range)
+    public int compareTo(RevisionRange range)
     {
         if (this == range)
             return 0;
 
-        Revision other = ((RevisionRange) range).getFromRevision();
+        Revision other = (range).getFromRevision();
         return RevisionRange.getRevisionAsLong(this.getFromRevision())
             .compareTo(RevisionRange.getRevisionAsLong(other));
     }