You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "GrantPSpencer (via GitHub)" <gi...@apache.org> on 2023/10/20 00:49:13 UTC
[PR] [helix-front] Minor version bump to 1.7.0 [helix]
GrantPSpencer opened a new pull request, #2676:
URL: https://github.com/apache/helix/pull/2676
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
N/A
### Description
Bump helix-front version, I should have done this in my [previous PR](https://github.com/apache/helix/pull/2672) - sorry!
(Write a concise description including what, why, how)
### Tests
- [ ] The following tests are written for this issue:
$ yarn test
```
Test Suites: 9 skipped, 35 passed, 35 of 44 total
Tests: 10 skipped, 38 passed, 48 total
Snapshots: 0 total
Time: 36.123 s
Ran all test suites.
✨ Done in 47.67s.
```
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] [helix-front] Minor version bump to 1.7.0 [helix]
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2676:
URL: https://github.com/apache/helix/pull/2676#issuecomment-1942880987
i was kind of surprised to see old thread :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] [helix-front] Minor version bump to 1.7.0 [helix]
Posted by "junkaixue (via GitHub)" <gi...@apache.org>.
junkaixue merged PR #2676:
URL: https://github.com/apache/helix/pull/2676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org