You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/17 14:28:43 UTC

[GitHub] [airflow] sekikn opened a new pull request #7749: [AIRFLOW-7026] Improve SparkSqlHook's error message

sekikn opened a new pull request #7749: [AIRFLOW-7026] Improve SparkSqlHook's error message
URL: https://github.com/apache/airflow/pull/7749
 
 
   * Replace self._conn.host in the error message with
     self._master, because the former is unused in
     SparkSqlHook actually.
   
   * Add self._sql into the error message, because it's
     the executed query or a file that contains it.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman merged pull request #7749: [AIRFLOW-7026] Improve SparkSqlHook's error message

Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #7749: [AIRFLOW-7026] Improve SparkSqlHook's error message
URL: https://github.com/apache/airflow/pull/7749
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7749: [AIRFLOW-7026] Improve SparkSqlHook's error message

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7749: [AIRFLOW-7026] Improve SparkSqlHook's error message
URL: https://github.com/apache/airflow/pull/7749#issuecomment-608016121
 
 
   Restarted the test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services