You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/21 05:59:18 UTC
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #5241: fix for test of subquerytable
tristaZero commented on a change in pull request #5241:
URL: https://github.com/apache/shardingsphere/pull/5241#discussion_r411891399
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/impl/OracleDMLVisitor.java
##########
@@ -474,4 +474,9 @@ public ASTNode visitGroupByClause(final GroupByClauseContext ctx) {
}
return new GroupBySegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), items);
}
+
+ @Override
+ public ASTNode visitSubquery(final OracleStatementParser.SubqueryContext ctx) {
Review comment:
Is it possible to use `SubqueryContext` instead of `OracleStatementParser.SubqueryContext`
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/impl/SQLServerDMLVisitor.java
##########
@@ -469,4 +469,9 @@ public ASTNode visitGroupByClause(final GroupByClauseContext ctx) {
}
return new GroupBySegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), items);
}
+
+ @Override
+ public ASTNode visitSubquery(final SQLServerStatementParser.SubqueryContext ctx) {
+ return visit(ctx.unionClause());
+ }
Review comment:
Do you think `SQL92DMLVisitor` need this function as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org