You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Remy Maucherat <re...@apache.org> on 2008/07/10 15:38:16 UTC

Re: svn commit: r675340 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

On Wed, 2008-07-09 at 20:50 +0000, markt@apache.org wrote:
> Author: markt
> Date: Wed Jul  9 13:50:18 2008
> New Revision: 675340
> 
> URL: http://svn.apache.org/viewvc?rev=675340&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45285
> Should look for annotations all the way up the class hierarchy

preDestroy and postConstruct apparently include a recursive trick to do
that. Probably all 3 should be similar.

Rémy



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r675340 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

Posted by Mark Thomas <ma...@apache.org>.
Mark Thomas wrote:
> Remy Maucherat wrote:
>> On Wed, 2008-07-09 at 20:50 +0000, markt@apache.org wrote:
>>> Author: markt
>>> Date: Wed Jul  9 13:50:18 2008
>>> New Revision: 675340
>>>
>>> URL: http://svn.apache.org/viewvc?rev=675340&view=rev
>>> Log:
>>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45285
>>> Should look for annotations all the way up the class hierarchy
>>
>> preDestroy and postConstruct apparently include a recursive trick to do
>> that. Probably all 3 should be similar.
> 
> The patch does the same thing but in a different way. I'll make them 
> consistent.

I couldn't make them consistent without changing the API so I have left it 
alone.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r675340 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

Posted by Mark Thomas <ma...@apache.org>.
Remy Maucherat wrote:
> On Wed, 2008-07-09 at 20:50 +0000, markt@apache.org wrote:
>> Author: markt
>> Date: Wed Jul  9 13:50:18 2008
>> New Revision: 675340
>>
>> URL: http://svn.apache.org/viewvc?rev=675340&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45285
>> Should look for annotations all the way up the class hierarchy
> 
> preDestroy and postConstruct apparently include a recursive trick to do
> that. Probably all 3 should be similar.

The patch does the same thing but in a different way. I'll make them 
consistent.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org