You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "lifeSo (via GitHub)" <gi...@apache.org> on 2023/06/02 08:20:51 UTC
[GitHub] [incubator-uniffle] lifeSo opened a new pull request, #923: [#854][FOLLOWUP] feat(mr): Add @Test to activate test case
lifeSo opened a new pull request, #923:
URL: https://github.com/apache/incubator-uniffle/pull/923
### What changes were proposed in this pull request?
Add @Test to activate test case
### Why are the changes needed?
Just for Add @Test to activate test case
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #923: [MINOR] improvement(mr): Add @Test to activate test case
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #923:
URL: https://github.com/apache/incubator-uniffle/pull/923#issuecomment-1573362294
> > It seems unrelated to #854. We use minor if this pr fix minor issue.
>
> I think it does not matter whether it related or not.
We should use correct titile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #923: [MINOR] improvement(mr): Add @Test to activate test case
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #923:
URL: https://github.com/apache/incubator-uniffle/pull/923#issuecomment-1573367891
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#923](https://app.codecov.io/gh/apache/incubator-uniffle/pull/923?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (873c88a) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/6471c5e8a9e11a8d9401d727a0e7d44b2287822e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6471c5e) will **increase** coverage by `1.83%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #923 +/- ##
============================================
+ Coverage 55.53% 57.37% +1.83%
Complexity 2246 2246
============================================
Files 341 321 -20
Lines 16626 14266 -2360
Branches 1327 1327
============================================
- Hits 9234 8185 -1049
+ Misses 6863 5622 -1241
+ Partials 529 459 -70
```
[see 22 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/923/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] lifeSo commented on pull request #923: [MINOR] improvement(mr): Add @Test to activate test case
Posted by "lifeSo (via GitHub)" <gi...@apache.org>.
lifeSo commented on PR #923:
URL: https://github.com/apache/incubator-uniffle/pull/923#issuecomment-1573359928
> It seems unrelated to #854. We use minor if this pr fix minor issue.
I think it does not matter whether it related or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #923: [MINOR] improvement(mr): Add @Test to activate test case
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #923:
URL: https://github.com/apache/incubator-uniffle/pull/923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #923: [#854][FOLLOWUP] feat(mr): Add @Test to activate test case
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #923:
URL: https://github.com/apache/incubator-uniffle/pull/923#issuecomment-1573357723
It seems unrelated to #854. We use minor if this pr fix minor issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org