[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34143: [SPARK-36890] Use default WebsocketPingInterval for Kubernetes watches

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #34143:
URL: https://github.com/apache/spark/pull/34143#discussion_r718801875



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
##########
@@ -88,7 +88,6 @@ private[spark] object SparkKubernetesClientFactory extends Logging {
     val config = new ConfigBuilder(autoConfigure(kubeContext.getOrElse(null)))
       .withApiVersion("v1")
       .withMasterUrl(master)
-      .withWebsocketPingInterval(0)

Review comment:
       This is an ancient code came from SPARK-18278.
   - https://github.com/apache/spark/pull/19468/files#diff-16671cf9d0bff95338158f5fe51d661c482abbcf0fba8515d920849effad66ebR69
   
   Are you using this code in your production? I'm wondering if there is any possibility of side-effect at the corner case, @Reamer . After this PR, is there a way to control this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org