You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jason Fehr (Code Review)" <ge...@cloudera.org> on 2024/03/28 02:32:00 UTC
[Impala-ASF-CR] IMPALA-12945: Fix Flaky Ticker Test
Jason Fehr has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21214
Change subject: IMPALA-12945: Fix Flaky Ticker Test
......................................................................
IMPALA-12945: Fix Flaky Ticker Test
The ticker test failed on an exhaustive release build. The
failure was because the total elapsed time was longer than
expected.
This change bumps up the margin of error from 1% to 2% to
give slightly more time on the more intensive builds.
Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
---
M be/src/util/ticker-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/21214/1
--
To view, visit http://gerrit.cloudera.org:8080/21214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
Gerrit-Change-Number: 21214
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
[Impala-ASF-CR] IMPALA-12945: Fix Flaky Ticker Test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21214 )
Change subject: IMPALA-12945: Fix Flaky Ticker Test
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10454/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
Gerrit-Change-Number: 21214
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 14:59:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12945: Fix Flaky Ticker Test
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21214 )
Change subject: IMPALA-12945: Fix Flaky Ticker Test
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this, LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/21214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
Gerrit-Change-Number: 21214
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 09:08:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12945: Fix Flaky Ticker Test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21214 )
Change subject: IMPALA-12945: Fix Flaky Ticker Test
......................................................................
IMPALA-12945: Fix Flaky Ticker Test
The ticker test failed on an exhaustive release build. The
failure was because the total elapsed time was longer than
expected.
This change bumps up the margin of error from 1% to 2% to
give slightly more time on the more intensive builds.
Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
Reviewed-on: http://gerrit.cloudera.org:8080/21214
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/ticker-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
Gerrit-Change-Number: 21214
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12945: Fix Flaky Ticker Test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21214 )
Change subject: IMPALA-12945: Fix Flaky Ticker Test
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
Gerrit-Change-Number: 21214
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 14:59:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12945: Fix Flaky Ticker Test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21214 )
Change subject: IMPALA-12945: Fix Flaky Ticker Test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
Gerrit-Change-Number: 21214
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 09:08:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12945: Fix Flaky Ticker Test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21214 )
Change subject: IMPALA-12945: Fix Flaky Ticker Test
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10447/
--
To view, visit http://gerrit.cloudera.org:8080/21214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
Gerrit-Change-Number: 21214
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 14:12:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12945: Fix Flaky Ticker Test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21214 )
Change subject: IMPALA-12945: Fix Flaky Ticker Test
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10447/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
Gerrit-Change-Number: 21214
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 09:08:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12945: Fix Flaky Ticker Test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21214 )
Change subject: IMPALA-12945: Fix Flaky Ticker Test
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15704/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
Gerrit-Change-Number: 21214
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 02:53:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12945: Fix Flaky Ticker Test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21214 )
Change subject: IMPALA-12945: Fix Flaky Ticker Test
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8cf03ae68fb3103c5bbc438c32f6565b8c406c
Gerrit-Change-Number: 21214
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 20:06:58 +0000
Gerrit-HasComments: No