You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Andras Salamon (JIRA)" <ji...@apache.org> on 2019/04/02 08:50:03 UTC
[jira] [Updated] (OOZIE-3461) CoordMaterializeTriggerService code
cleanup
[ https://issues.apache.org/jira/browse/OOZIE-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andras Salamon updated OOZIE-3461:
----------------------------------
Description:
It seems to me don't really use the {{delayedCallables}} and {{delay}} variables in {{CoordMaterializeTriggerService.CoordMaterializeTriggerRunnable}} class. We only add items to {{callables}} and not to {{delayedCallables}}. We could remove this part of the class.
It should be also useful to log the lock acquiring and not only the releasing ( like in [PauseTransitService|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/PauseTransitService.java#L86] )
was:It seems to me don't really use the {{delayedCallables}} and {{delay}} variables in {{CoordMaterializeTriggerService.CoordMaterializeTriggerRunnable}} class. We only add items to {{callables}} and not to {{delayedCallables}}. We could remove this part of the class.
> CoordMaterializeTriggerService code cleanup
> -------------------------------------------
>
> Key: OOZIE-3461
> URL: https://issues.apache.org/jira/browse/OOZIE-3461
> Project: Oozie
> Issue Type: Task
> Reporter: Andras Salamon
> Assignee: duan xiong
> Priority: Minor
>
> It seems to me don't really use the {{delayedCallables}} and {{delay}} variables in {{CoordMaterializeTriggerService.CoordMaterializeTriggerRunnable}} class. We only add items to {{callables}} and not to {{delayedCallables}}. We could remove this part of the class.
> It should be also useful to log the lock acquiring and not only the releasing ( like in [PauseTransitService|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/PauseTransitService.java#L86] )
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)