You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/12/06 19:14:49 UTC
[GitHub] [couchdb] nickva opened a new pull request, #4294: Fix flaky checkpointing smoosh test
nickva opened a new pull request, #4294:
URL: https://github.com/apache/couchdb/pull/4294
This may not be a 100% fix just doing extra asserts that file operations have succeeded and making to wait for the compactor to exit and match the exit reason exactly, to make sure we killed and it does as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #4294: Fix flaky checkpointing smoosh test
Posted by GitBox <gi...@apache.org>.
nickva commented on PR #4294:
URL: https://github.com/apache/couchdb/pull/4294#issuecomment-1339915587
> Did you want to leave the remaining `?debugHere` statements in case this doesn't fix it?
>
> ```
> smoosh_tests:27: -smoosh_test_/0-fun-10- (t_checkpointing_works)...test/smoosh_tests.erl:262:<0.1776.0>: <-
> test/smoosh_tests.erl:264:<0.1776.0>: <-
> test/smoosh_tests.erl:267:<0.1776.0>: <-
> test/smoosh_tests.erl:269:<0.1776.0>: <-
> [0.024 s] ok
> ```
Yeah, I figured we'd leave some logging in there for now. If a few months pass and these don't fail we can remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #4294: Fix flaky checkpointing smoosh test
Posted by GitBox <gi...@apache.org>.
nickva merged PR #4294:
URL: https://github.com/apache/couchdb/pull/4294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org