You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Robert Muir <rc...@gmail.com> on 2010/09/21 23:19:19 UTC

running tests / svn:eol-style missing on some files?

Hello,

I am trying to setup a harmony build environment, and I can build everything
(via ant build), but I have two questions

1. I have difficulty running tests: e.g. if i run 'ant test' from classlib,
I get errors like this:

    [junit] Failed to open JVM DLL:
/home/rmuir/workspace/harmony-trunk/classlib/deploy/jdk/jre/bin/default/harmonyvm
(/home/rmuir/workspace/harmony-trunk/classlib/deploy/jdk/jre/bin/default/libharmonyvm.so:
cannot open shared object file: No such file or directory)

I know my previous build put this stuff in /target, but not in deploy. I
found i could trick the tests setting -Dhy.hdk, but this doesn't seem right.

2. I think some files are missing svn:eol-style. For example, although i
have not modified anything I see:

M
classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/net/URLEncoderTest.java
M
classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/io/BufferedInputStreamTest.java
M
classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/io/InputStreamReaderTest.java
M
classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/util/FormatterTest.java

Can we set svn:eol-style=native for these files?

Thanks in advance for any help,
Robert

-- 
Robert Muir
rcmuir@gmail.com

Re: running tests / svn:eol-style missing on some files?

Posted by sebb <se...@gmail.com>.
On 22 September 2010 18:24, Mark Hindess <ma...@googlemail.com> wrote:
>
> In message <AA...@mail.gmail.com>,
> sebb writes:
>>
>> On 22 September 2010 12:53, Mark Hindess <ma...@googlemail.com>
>> wrote:
>> >
>> > In message <4C...@gmail.com>, Tim Ellison writes:
>> >>
>> >> On 21/Sep/2010 22:19, Robert Muir wrote:
>> >> > 2. I think some files are missing svn:eol-style. For example, although
>> >> > i have not modified anything I see:
>> >> >
>> >> > M
>> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/
>> java/net/URLEncoderTest.java
>> >> > M
>> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/
>> java/io/BufferedInputStreamTest.java
>> >> > M
>> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/
>> java/io/InputStreamReaderTest.java
>> >> > M
>> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/
>> java/util/FormatterTest.java
>> >> >
>> >> > Can we set svn:eol-style=native for these files?
>> >>
>> >> I fixed these specific files @r999716, but it would be good if Mark
>> >> could run his script to check if there are any others that need setting.
>> >
>> > Fixed at r999793 and r999851.
>>
>> Here are a few more possible ones for
>> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk:
>>
>> svn ps svn:mime-type application/octet-stream
>> classlib/modules/security/src/test/resources/hyts_badpem.cer
>> svn ps svn:eol-style native
>> classlib/support/src/test/java/tests/resources/hyts_checkInput.txt
>> svn ps svn:eol-style native drlvm/vm/gc_gen/src/LICENSE
>> svn ps svn:eol-style native drlvm/vm/gc_gen/src/NOTICE
>> svn ps svn:eol-style native
>> classlib/modules/beans/src/test/resources/xml/ChangedObject.xml
>> svn ps svn:eol-style native
>> classlib/modules/beans/src/test/resources/xml/ClassID.xml
>> svn ps svn:eol-style native
>> classlib/modules/beans/src/test/resources/xml/ObjectID.xml
>> svn ps svn:eol-style native
>> classlib/modules/beans/src/test/resources/xml/StaticField.xml
>>
>> There are also 177 files which have the executable bit set, for example:
>>
>> svn pd svn:executable classlib/depends/files/libhyempty.so
>> svn pd svn:executable
>> classlib/modules/awt/src/main/java/common/java/awt/ActiveEvent.java
>> svn pd svn:executable
>> classlib/modules/awt/src/main/java/common/java/awt/Adjustable.java
>> svn pd svn:executable
>> classlib/modules/awt/src/main/java/common/java/awt/AlphaComposite.java
>>
>> There's rarely a need for this bit to be set; usually if it needs to
>> be set it should be set as part of creating the archives.
>>
>> I can provide the full list if you wish (or you could just delete it
>> from all files).
>
> Thanks Sebb.
>
> I'd intentionally left the test resources as I wanted to make sure
> fixing them didn't break any tests.

If the specific EOL matters, then it is sensible to set it.

These files don't currently have any EOL setting.
All the other XML files in the directory have go eol-style:native

> Oddly LICENSE and NOTICE files are
> missing from the svn auto-props configuration I pulled from the link
> on the NewCommitters page of the Harmony wiki - perhaps they should be
> added?

Can one add files with no extension?

>  - and my script was using that as input.
>
> I've not actually checked any other properties but I'll take a look at
> the svn:mime-type or svn:executable properties shortly.  (No need to
> send a full list.)
>
> Any other properties that are worth checking?
>
> Regards,
>  Mark.
>
>
>

Re: running tests / svn:eol-style missing on some files?

Posted by Robert Muir <rc...@gmail.com>.
On Wed, Sep 22, 2010 at 1:24 PM, Mark Hindess
<ma...@googlemail.com>wrote:

>
> Any other properties that are worth checking?
>
>
expanding svn:ignore can be helpful too (way less important since you would
have to actually svn add one of these)

for example I see the following because i use eclipse:
?       .project
?       .classpath
?       bin
?       .settings

i don't what constitutes a "good list" across the various IDEs etc, but over
in lucene we have:
classes
build
dist
*~
velocity.log
build.properties
.idea
*.iml
*.ipr
*.iws
.project
.classpath
.settings
prj.el

-- 
Robert Muir
rcmuir@gmail.com

Re: running tests / svn:eol-style missing on some files?

Posted by Mark Hindess <ma...@googlemail.com>.
In message <AA...@mail.gmail.com>,
sebb writes:
>
> On 22 September 2010 12:53, Mark Hindess <ma...@googlemail.com>
> wrote:
> >
> > In message <4C...@gmail.com>, Tim Ellison writes:
> >>
> >> On 21/Sep/2010 22:19, Robert Muir wrote:
> >> > 2. I think some files are missing svn:eol-style. For example, although
> >> > i have not modified anything I see:
> >> >
> >> > M
> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/
> java/net/URLEncoderTest.java
> >> > M
> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/
> java/io/BufferedInputStreamTest.java
> >> > M
> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/
> java/io/InputStreamReaderTest.java
> >> > M
> >> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/
> java/util/FormatterTest.java
> >> >
> >> > Can we set svn:eol-style=native for these files?
> >>
> >> I fixed these specific files @r999716, but it would be good if Mark
> >> could run his script to check if there are any others that need setting.
> >
> > Fixed at r999793 and r999851.
> 
> Here are a few more possible ones for
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk:
> 
> svn ps svn:mime-type application/octet-stream
> classlib/modules/security/src/test/resources/hyts_badpem.cer
> svn ps svn:eol-style native
> classlib/support/src/test/java/tests/resources/hyts_checkInput.txt
> svn ps svn:eol-style native drlvm/vm/gc_gen/src/LICENSE
> svn ps svn:eol-style native drlvm/vm/gc_gen/src/NOTICE
> svn ps svn:eol-style native
> classlib/modules/beans/src/test/resources/xml/ChangedObject.xml
> svn ps svn:eol-style native
> classlib/modules/beans/src/test/resources/xml/ClassID.xml
> svn ps svn:eol-style native
> classlib/modules/beans/src/test/resources/xml/ObjectID.xml
> svn ps svn:eol-style native
> classlib/modules/beans/src/test/resources/xml/StaticField.xml
>
> There are also 177 files which have the executable bit set, for example:
> 
> svn pd svn:executable classlib/depends/files/libhyempty.so
> svn pd svn:executable
> classlib/modules/awt/src/main/java/common/java/awt/ActiveEvent.java
> svn pd svn:executable
> classlib/modules/awt/src/main/java/common/java/awt/Adjustable.java
> svn pd svn:executable
> classlib/modules/awt/src/main/java/common/java/awt/AlphaComposite.java
> 
> There's rarely a need for this bit to be set; usually if it needs to
> be set it should be set as part of creating the archives.
>
> I can provide the full list if you wish (or you could just delete it
> from all files).

Thanks Sebb.

I'd intentionally left the test resources as I wanted to make sure
fixing them didn't break any tests.  Oddly LICENSE and NOTICE files are
missing from the svn auto-props configuration I pulled from the link
on the NewCommitters page of the Harmony wiki - perhaps they should be
added? - and my script was using that as input.

I've not actually checked any other properties but I'll take a look at
the svn:mime-type or svn:executable properties shortly.  (No need to
send a full list.)

Any other properties that are worth checking?

Regards,
 Mark.

Re: running tests / svn:eol-style missing on some files?

Posted by sebb <se...@gmail.com>.
On 22 September 2010 12:53, Mark Hindess <ma...@googlemail.com> wrote:
>
> In message <4C...@gmail.com>, Tim Ellison writes:
>>
>> On 21/Sep/2010 22:19, Robert Muir wrote:
>> > 2. I think some files are missing svn:eol-style. For example, although i
>> > have not modified anything I see:
>> >
>> > M
>> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/net/URLEncoderTest.java
>> > M
>> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/io/BufferedInputStreamTest.java
>> > M
>> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/io/InputStreamReaderTest.java
>> > M
>> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/util/FormatterTest.java
>> >
>> > Can we set svn:eol-style=native for these files?
>>
>> I fixed these specific files @r999716, but it would be good if Mark
>> could run his script to check if there are any others that need setting.
>
> Fixed at r999793 and r999851.

Here are a few more possible ones for
https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk:

svn ps svn:mime-type application/octet-stream
classlib/modules/security/src/test/resources/hyts_badpem.cer
svn ps svn:eol-style native
classlib/support/src/test/java/tests/resources/hyts_checkInput.txt
svn ps svn:eol-style native drlvm/vm/gc_gen/src/LICENSE
svn ps svn:eol-style native drlvm/vm/gc_gen/src/NOTICE
svn ps svn:eol-style native
classlib/modules/beans/src/test/resources/xml/ChangedObject.xml
svn ps svn:eol-style native
classlib/modules/beans/src/test/resources/xml/ClassID.xml
svn ps svn:eol-style native
classlib/modules/beans/src/test/resources/xml/ObjectID.xml
svn ps svn:eol-style native
classlib/modules/beans/src/test/resources/xml/StaticField.xml

There are also 177 files which have the executable bit set, for example:

svn pd svn:executable classlib/depends/files/libhyempty.so
svn pd svn:executable
classlib/modules/awt/src/main/java/common/java/awt/ActiveEvent.java
svn pd svn:executable
classlib/modules/awt/src/main/java/common/java/awt/Adjustable.java
svn pd svn:executable
classlib/modules/awt/src/main/java/common/java/awt/AlphaComposite.java

There's rarely a need for this bit to be set; usually if it needs to
be set it should be set as part of creating the archives.

I can provide the full list if you wish (or you could just delete it
from all files).

Re: running tests / svn:eol-style missing on some files?

Posted by Mark Hindess <ma...@googlemail.com>.
In message <4C...@gmail.com>, Tim Ellison writes:
>
> On 21/Sep/2010 22:19, Robert Muir wrote:
> > 2. I think some files are missing svn:eol-style. For example, although i
> > have not modified anything I see:
> > 
> > M
> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/net/URLEncoderTest.java
> > M
> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/io/BufferedInputStreamTest.java
> > M
> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/io/InputStreamReaderTest.java
> > M
> > classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/util/FormatterTest.java
> > 
> > Can we set svn:eol-style=native for these files?
> 
> I fixed these specific files @r999716, but it would be good if Mark
> could run his script to check if there are any others that need setting.

Fixed at r999793 and r999851.

-Mark.

-- 
perl -0e 'sub r{open$s,"svn info http://svn.apache.org/repos/asf|"||exit;$_=
<$s>;/^Rev\w+:\s(\d+)/m&&$1}sub l{~~localtime$t}$g=10**6;$e="";while(1){$t=time
;$r=r;$r>=$g&&last;if(@p){$p=@p>10?shift@p:$p[0];$d=$r-$p->[1];$d||next;$e=l+(
$g-$r)*($t-$p->[0])/$d}print l," $r $e\n";push@p,[$t,$r];sleep 300;}'

Re: running tests / svn:eol-style missing on some files?

Posted by Tim Ellison <t....@gmail.com>.
On 21/Sep/2010 22:19, Robert Muir wrote:
> 2. I think some files are missing svn:eol-style. For example, although i
> have not modified anything I see:
> 
> M
> classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/net/URLEncoderTest.java
> M
> classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/io/BufferedInputStreamTest.java
> M
> classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/io/InputStreamReaderTest.java
> M
> classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/util/FormatterTest.java
> 
> Can we set svn:eol-style=native for these files?

I fixed these specific files @r999716, but it would be good if Mark
could run his script to check if there are any others that need setting.

Regards,
Tim

Re: running tests / svn:eol-style missing on some files?

Posted by Tim Ellison <t....@gmail.com>.
On 22/Sep/2010 01:39, Robert Muir wrote:
> On Tue, Sep 21, 2010 at 6:58 PM, Mark Hindess
> <ma...@googlemail.com>wrote:
> 
>> I'd recommend running the federated build ... i.e. "ant build test" in
>> /home/rmuir/workspace/harmony-trunk in your case.
>>
>>
> Thank you! I knew I was missing something.
> 
> Could we add something like the following below, so that the "test" target
> shows up in the toplevel ant projecthelp (ant -p) ?

Done @ r999715.

Regards,
Tim

Re: running tests / svn:eol-style missing on some files?

Posted by Robert Muir <rc...@gmail.com>.
On Tue, Sep 21, 2010 at 6:58 PM, Mark Hindess
<ma...@googlemail.com>wrote:

>
> I'd recommend running the federated build ... i.e. "ant build test" in
> /home/rmuir/workspace/harmony-trunk in your case.
>
>
Thank you! I knew I was missing something.

Could we add something like the following below, so that the "test" target
shows up in the toplevel ant projecthelp (ant -p) ?

Index: build.xml
===================================================================
--- build.xml (revision 999631)
+++ build.xml (working copy)
@@ -787,7 +787,7 @@
         <chmod file="${hy.target}/src/debian/rules" perm="ugo+x" />
     </target>

-    <target name="test" depends="clean-tests">
+    <target name="test" depends="clean-tests" description="Runs all tests">
         <ant antfile="${hy.target}/hdk/build/test/build.xml"
              target="test" inheritAll="false" >
             <propertyset refid="required.props" />

-- 
Robert Muir
rcmuir@gmail.com

Re: running tests / svn:eol-style missing on some files?

Posted by Mark Hindess <ma...@googlemail.com>.
In message <AA...@mail.gmail.com>,
Robert Muir writes:
>
> Hello,
> 
> I am trying to setup a harmony build environment, and I can build everything
> (via ant build), but I have two questions
> 
> 1. I have difficulty running tests: e.g. if i run 'ant test' from classlib,
> I get errors like this:
> 
>     [junit] Failed to open JVM DLL:
> /home/rmuir/workspace/harmony-trunk/classlib/deploy/jdk/jre/bin/default/harmo
> nyvm
> (/home/rmuir/workspace/harmony-trunk/classlib/deploy/jdk/jre/bin/default/libharmonyvm.so:
> cannot open shared object file: No such file or directory)
> 
> I know my previous build put this stuff in /target, but not in deploy. I
> found i could trick the tests setting -Dhy.hdk, but this doesn't seem right.

I'd recommend running the federated build ... i.e. "ant build test" in 
/home/rmuir/workspace/harmony-trunk in your case.

If you only want to run a subset of tests you can do:

  ant -Dbuild.module=luni test

or even:

  ant -Dbuild.module=luni -Dtest.case=org.apache....FormatterTest test

> 2. I think some files are missing svn:eol-style. For example, although i
> have not modified anything I see:
> 
> M
> classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/
> net/URLEncoderTest.java
> M
> classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/
> io/BufferedInputStreamTest.java
> M
> classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/
> io/InputStreamReaderTest.java
> M
> classlib/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/
> util/FormatterTest.java
> 
> Can we set svn:eol-style=native for these files?

I'll check all of the .java files and fix these in the morning.

Thanks,
 Mark.