You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2023/09/16 09:01:45 UTC
[tomcat] branch 8.5.x updated (a5e30c15f4 -> 0f6899cb98)
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from a5e30c15f4 Update changelog
new bf7bd10432 Update false positives for FileUpload
new 7a4d356d70 Fix SpotBugs warning
new 0f6899cb98 Suppress a false positive
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
res/spotbugs/filter-false-positives.xml | 29 ++++++----------------
.../tomcat/websocket/server/TesterWsClient.java | 3 +++
2 files changed, 10 insertions(+), 22 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 03/03: Suppress a false positive
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 0f6899cb98f2fc70ef753701886bbdfce1a109f4
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Sat Sep 16 10:00:03 2023 +0100
Suppress a false positive
---
res/spotbugs/filter-false-positives.xml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml
index 70baa748a0..64ea238d31 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -1041,6 +1041,12 @@
<Method name="waitFor" />
<Bug pattern="WA_NOT_IN_LOOP" />
</Match>
+ <Match>
+ <!-- Surrounding loop takes correct action for all return values. -->
+ <Class name="org.apache.coyote.http2.WindowAllocationManager" />
+ <Method name="waitFor" />
+ <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
+ </Match>
<Match>
<!-- Returning null is required by the EL specification -->
<Class name="org.apache.el.lang.ELSupport" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 01/03: Update false positives for FileUpload
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit bf7bd10432f02e4a2428ef4d33dfc3a2d3081948
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Sat Sep 16 09:56:50 2023 +0100
Update false positives for FileUpload
---
res/spotbugs/filter-false-positives.xml | 23 +----------------------
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml
index 9794f86322..70baa748a0 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -1547,33 +1547,12 @@
<Method name="processCookieHeader"/>
<Bug code="SF" />
</Match>
- <Match>
- <!-- the platform default encoding is a fallback -->
- <Class name="org.apache.tomcat.util.http.fileupload.MultipartStream"/>
- <Method name="readHeaders"/>
- <Bug code="Dm" />
- </Match>
<Match>
<!-- Deletion failure should never happen -->
<Class name="org.apache.tomcat.util.http.fileupload.disk.DiskFileItem"/>
- <Or>
- <Method name="delete"/>
- <Method name="finalize"/>
- </Or>
+ <Method name="finalize"/>
<Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
</Match>
- <Match>
- <!-- the platform default encoding is a fallback -->
- <Class name="org.apache.tomcat.util.http.fileupload.disk.DiskFileItem"/>
- <Method name="getString"/>
- <Bug code="Dm" />
- </Match>
- <Match>
- <!-- the platform default encoding is deliberate -->
- <Class name="org.apache.tomcat.util.http.fileupload.util.Streams"/>
- <Method name="asString"/>
- <Bug code="Dm" />
- </Match>
<Match>
<!-- Fall-through expected -->
<Class name="org.apache.tomcat.util.http.parser.Cookie" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 02/03: Fix SpotBugs warning
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 7a4d356d70c5871c7efd33adcd29fcf99642a0cf
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Sat Sep 16 09:57:16 2023 +0100
Fix SpotBugs warning
---
test/org/apache/tomcat/websocket/server/TesterWsClient.java | 3 +++
1 file changed, 3 insertions(+)
diff --git a/test/org/apache/tomcat/websocket/server/TesterWsClient.java b/test/org/apache/tomcat/websocket/server/TesterWsClient.java
index c90aa23ed6..5c47dd21c7 100644
--- a/test/org/apache/tomcat/websocket/server/TesterWsClient.java
+++ b/test/org/apache/tomcat/websocket/server/TesterWsClient.java
@@ -76,6 +76,9 @@ public class TesterWsClient {
BufferedReader in = new BufferedReader(new InputStreamReader(socket.getInputStream()));
String line = in.readLine();
// line expected to be "HTTP/1.1 nnn "
+ if (line == null) {
+ throw new IOException("No response line");
+ }
int result = Integer.parseInt(line.substring(9, 12));
while (line != null && !line.isEmpty()) {
line = in.readLine();
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org