You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/26 07:58:47 UTC
[GitHub] [spark] itholic opened a new pull request, #36685: [SPARK-39253][DOCS][PYTHON][3.3] Improve PySpark API reference to be more readable
itholic opened a new pull request, #36685:
URL: https://github.com/apache/spark/pull/36685
### What changes were proposed in this pull request?
Hotfix https://github.com/apache/spark/pull/36647 for branch-3.3.
### Why are the changes needed?
The improvement of document readability will also improve the usability for PySpark.
### Does this PR introduce _any_ user-facing change?
Yes, now the documentation is categorized by its class or their own purpose more clearly as below:
<img width="270" alt="Screen Shot 2022-05-24 at 1 50 23 PM" src="https://user-images.githubusercontent.com/44108233/169951517-f8b9cb72-7408-46d6-8cd7-15ae890a7a7f.png">
### How was this patch tested?
The existing test should cover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #36685: [SPARK-39253][DOCS][PYTHON][3.3] Improve PySpark API reference to be more readable
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #36685:
URL: https://github.com/apache/spark/pull/36685#discussion_r882418156
##########
python/docs/source/reference/pyspark.sql/avro.rst:
##########
@@ -0,0 +1,28 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+====
+Avro
+====
+.. currentmodule:: pyspark.sql.avro.functions
+
+.. autosummary::
+ :toctree: api/
+
+ from_avro
+ to_avro
Review Comment:
This is missing from master. Let me create a follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #36685: [SPARK-39253][DOCS][PYTHON][3.3] Improve PySpark API reference to be more readable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #36685: [SPARK-39253][DOCS][PYTHON][3.3] Improve PySpark API reference to be more readable
URL: https://github.com/apache/spark/pull/36685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36685: [SPARK-39253][DOCS][PYTHON][3.3] Improve PySpark API reference to be more readable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36685:
URL: https://github.com/apache/spark/pull/36685#issuecomment-1138393927
Merged to branch-3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org