[GitHub] [spark] grundprinzip commented on a diff in pull request #41138: [PYTHON][SPARK-43457][CONNECT] Augument user agent with OS and Python versions

["grundprinzip (via GitHub)" <gi...@apache.org>]

grundprinzip commented on code in PR #41138:
URL: https://github.com/apache/spark/pull/41138#discussion_r1191346077


##########
python/pyspark/sql/connect/client.py:
##########
@@ -299,7 +300,11 @@ def userAgent(self) -> str:
             raise SparkConnectException(
                 f"'user_agent' parameter should not exceed 2048 characters, found {len} characters."
             )
-        return user_agent
+        return " ".join([
+            user_agent,

Review Comment:
   if we put the other two values first then we have "guarantee" on the os and python version as the first two fields. 
   
   In addition, we should put the spark version here as well -> `from pyspark.version import __version__`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org