Re: [MyFaces 2] visitTree

[Michael Kurz <mi...@gmx.at>]

Hi,

I currently try to get f:ajax running inside a composite component. So I 
  would also say it is necessary to include the facets (use 
getFacetsAndChildren() instead of getChildren()) in visitTree().

I already fixed this issue in UIComponent.visitTree() (see [1]), BUT 
there is a potential conflict with UIData.visitTree() (also see [2]). 
The result, however, is that facets of columns are visited twice. I 
noticed this because UIDataTest.testVisitTree() fails unless the line 
expecting the column facet is in the code twice.

I tried the same example with Mojarra with the same result: the column 
facet is visited twice.

regards
Michael

[1]: https://issues.apache.org/jira/browse/MYFACES-2475
[2]: https://issues.apache.org/jira/browse/MYFACES-2137

Matthias Wessendorf schrieb:
> Hi,
> 
> checking a bit the diff between visitTree() in MyFaces2 and Trinidad 1.2.x.
> 
> In MyFaces2, I see that on the ACCEPT case the just ask for the
> children, but not for the facets.
> Just an oversight? I mean, sure the spec (and its javadoc) don't say
> much... however the spec's
> visitTree() has been designed having Trinidad in mind, so I think it is fine...
> 
> thanks,
> matthias
> 

Re: [MyFaces 2] visitTree

[Michael Kurz <mi...@gmx.at>]

Matthias Wessendorf schrieb:
> On Thu, Jan 7, 2010 at 4:42 PM, Michael Kurz <mi...@gmx.at> wrote:
>> Hi,
>>
>> I currently try to get f:ajax running inside a composite component. So I
>>  would also say it is necessary to include the facets (use
>> getFacetsAndChildren() instead of getChildren()) in visitTree().
> 
> maybe we want to check if there are children/facets (via the ...Count() method)
> => that is faster

I'll have a look at that.

>> I tried the same example with Mojarra with the same result: the column facet
>> is visited twice.
> 
> Do you mind to also file a ticket against them ? 

Yes, we can!

-Michi

Re: [MyFaces 2] visitTree

[Matthias Wessendorf <ma...@apache.org>]

On Thu, Jan 7, 2010 at 4:42 PM, Michael Kurz <mi...@gmx.at> wrote:
> Hi,
>
> I currently try to get f:ajax running inside a composite component. So I
>  would also say it is necessary to include the facets (use
> getFacetsAndChildren() instead of getChildren()) in visitTree().

maybe we want to check if there are children/facets (via the ...Count() method)
=> that is faster

>
> I already fixed this issue in UIComponent.visitTree() (see [1]), BUT there
> is a potential conflict with UIData.visitTree() (also see [2]). The result,
> however, is that facets of columns are visited twice. I noticed this because
> UIDataTest.testVisitTree() fails unless the line expecting the column facet
> is in the code twice.

:-)

>
> I tried the same example with Mojarra with the same result: the column facet
> is visited twice.

Do you mind to also file a ticket against them ?

-Matthias

>
> regards
> Michael
>
> [1]: https://issues.apache.org/jira/browse/MYFACES-2475
> [2]: https://issues.apache.org/jira/browse/MYFACES-2137
>
> Matthias Wessendorf schrieb:
>>
>> Hi,
>>
>> checking a bit the diff between visitTree() in MyFaces2 and Trinidad
>> 1.2.x.
>>
>> In MyFaces2, I see that on the ACCEPT case the just ask for the
>> children, but not for the facets.
>> Just an oversight? I mean, sure the spec (and its javadoc) don't say
>> much... however the spec's
>> visitTree() has been designed having Trinidad in mind, so I think it is
>> fine...
>>
>> thanks,
>> matthias
>>
>
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf