You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2018/12/29 11:55:50 UTC
[GitHub] [incubator-dubbo] codecov-io commented on issue #3096: Code review config center

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3096?src=pr&el=h1) Report
> Merging [#3096](https://codecov.io/gh/apache/incubator-dubbo/pull/3096?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f99f0158f1206ab5cadc1dfac1b373ebee25ebbd?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `43.66%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3096?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3096      +/-   ##
============================================
- Coverage     63.56%   63.48%   -0.08%     
  Complexity       75       75              
============================================
  Files           653      652       -1     
  Lines         28218    28199      -19     
  Branches       4803     4804       +1     
============================================
- Hits          17936    17903      -33     
- Misses         8009     8025      +16     
+ Partials       2273     2271       -2
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3096?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/dubbo/common/config/SystemConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL1N5c3RlbUNvbmZpZ3VyYXRpb24uamF2YQ==) | `60% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...figcenter/support/nop/NopDynamicConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L25vcC9Ob3BEeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `83.33% <ø> (+23.33%)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/common/config/EnvironmentConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0Vudmlyb25tZW50Q29uZmlndXJhdGlvbi5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/common/config/PropertiesConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL1Byb3BlcnRpZXNDb25maWd1cmF0aW9uLmphdmE=) | `66.66% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/dubbo/common/config/CompositeConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbXBvc2l0ZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `60.71% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...che/dubbo/common/config/InmemoryConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0lubWVtb3J5Q29uZmlndXJhdGlvbi5qYXZh) | `57.14% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ter/support/apollo/ApolloDynamicConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L2Fwb2xsby9BcG9sbG9EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/dubbo/configcenter/DynamicConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...bbo/common/config/AbstractPrefixConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0Fic3RyYWN0UHJlZml4Q29uZmlndXJhdGlvbi5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/dubbo/common/config/Configuration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb24uamF2YQ==) | `38.23% <38.23%> (ø)` | `0 <0> (?)` | |
| ... and [13 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3096/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3096?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3096?src=pr&el=footer). Last update [f99f015...e661d42](https://codecov.io/gh/apache/incubator-dubbo/pull/3096?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3096 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org