[GitHub] [commons-net] garydgregory commented on a diff in pull request #162: Add FTPFile tests and fix javadoc typos

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-net/pull/162#discussion_r1252907537


##########
src/main/java/org/apache/commons/net/ftp/FTPFile.java:
##########
@@ -330,13 +330,14 @@ public void setName(final String name) {
     }
 
     /**
-     * Sets if the given access group (one of the <code> _ACCESS </code> constants) has the given access permission (one of the <code> _PERMISSION </code>
+     * Sets if the given access group (one of the {@code _ACCESS} constants) has the given access permission (one of the {@code _PERMISSION}
      * constants) to the file.
      *
-     * @param access     The access group (one of the <code> _ACCESS </code> constants)
-     * @param permission The access permission (one of the <code> _PERMISSION </code> constants)
-     * @param value      True if permission is allowed, false if not.
+     * @param access     The access group (one of the {@code _ACCESS} constants)
+     * @param permission The access permission (one of the {@code _PERMISSION} constants)
+     * @param value      {@code true} if permission is allowed, {@code false} if not.
      * @throws ArrayIndexOutOfBoundsException if either of the parameters is out of range
+     * @throws NullPointerException if you're trying to set permission of an invalid file

Review Comment:
   How can an NPE happen here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org