[GitHub] [iceberg] sshkvar commented on pull request #2854: Spark catalog: fixed hardcoded purge option in drop table action

[GitBox <gi...@apache.org>]

sshkvar commented on pull request #2854:
URL: https://github.com/apache/iceberg/pull/2854#issuecomment-886523709


   > For Spark, my understanding was that we were gong to respect the `PURGE` information coming from the SQL command. Am I fully mistaken or is this for a different issue?
   
   In current implementation we ignoring purge information and always send `true` from [Spark Catalog](https://github.com/apache/iceberg/blob/master/spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java#L237) to [Hive catalog](https://github.com/apache/iceberg/blob/b623b074c6242ac3b48fce8712dedd7f97e6ee5b/api/src/main/java/org/apache/iceberg/catalog/Catalog.java#L284)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org