You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/31 07:53:26 UTC
[GitHub] [spark] itholic opened a new pull request, #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
itholic opened a new pull request, #38447:
URL: https://github.com/apache/spark/pull/38447
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to introduce new error class `UNCLOSED_BRACKETED_COMMENT`, by updating the existing legacy temp error class `_LEGACY_ERROR_TEMP_0055 `.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We should use appropriate error class name that matches the error message.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
The existing CI should pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
itholic commented on PR #38447:
URL: https://github.com/apache/spark/pull/38447#issuecomment-1305261082
Oh, `SparkThrowableSuite` failed. Let me take a look, soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
URL: https://github.com/apache/spark/pull/38447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38447:
URL: https://github.com/apache/spark/pull/38447#discussion_r1010126072
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala:
##########
@@ -608,8 +608,12 @@ private[sql] object QueryParsingErrors extends QueryErrorsBase {
}
def unclosedBracketedCommentError(command: String, position: Origin): Throwable = {
- new ParseException(Some(command), "Unclosed bracketed comment", position, position,
- Some("_LEGACY_ERROR_TEMP_0055"))
+ new ParseException(
+ Some(command),
+ "Found an unclosed bracketed comment. Please, append */ at the end of the comment.",
Review Comment:
Please, don't duplicate the error message here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #38447:
URL: https://github.com/apache/spark/pull/38447#discussion_r1012485332
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala:
##########
@@ -608,8 +608,12 @@ private[sql] object QueryParsingErrors extends QueryErrorsBase {
}
def unclosedBracketedCommentError(command: String, position: Origin): Throwable = {
- new ParseException(Some(command), "Unclosed bracketed comment", position, position,
- Some("_LEGACY_ERROR_TEMP_0055"))
+ new ParseException(
+ Some(command),
+ "Found an unclosed bracketed comment. Please, append */ at the end of the comment.",
Review Comment:
I think maybe If we don't specify the message here, then `null` is returned, so the `CliSuite.SPARK-37555: spark-sql should pass last unclosed comment to backend` failed as below:
```
CliSuite.SPARK-37555: spark-sql should pass last unclosed comment to backend
org.scalatest.exceptions.TestFailedException:
=======================
CliSuite failure output
=======================
Spark SQL CLI command line: ../../bin/spark-sql --master local --driver-java-options -Dderby.system.durability=test --conf spark.ui.enabled=false --hiveconf javax.jdo.option.ConnectionURL=jdbc:derby:;databaseName=/home/runner/work/spark/spark/target/tmp/spark-346cf558-8a95-43f1-b893-81f6a5571f3f;create=true --hiveconf hive.exec.scratchdir=/home/runner/work/spark/spark/target/tmp/spark-f108bccb-3f71-4854-aa70-c18ea721617c --hiveconf conf1=conftest --hiveconf conf2=1 --hiveconf hive.metastore.warehouse.dir=/home/runner/work/spark/spark/target/tmp/spark-86d39e14-55f9-437b-a676-7a5cabd58904
Exception: java.util.concurrent.TimeoutException: Futures timed out after [2 minutes]
Failed to capture next expected output "Found an unclosed bracketed comment." within 2 minutes.
2022-10-31 19:36:30.434 - stderr> Setting default log level to "WARN".
2022-10-31 19:36:30.434 - stderr> To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
2022-10-31 19:36:41.979 - stderr> Spark master: local, Application Id: local-1667270193279
2022-10-31 19:36:43.351 - stdout> spark-sql> /* SELECT /*+ HINT() 4; */;
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.119 - stderr> [PARSE_SYNTAX_ERROR] Syntax error at or near ';'(line 1, pos 26)
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.119 - stderr> == SQL ==
2022-10-31 19:36:44.119 - stderr> /* SELECT /*+ HINT() 4; */;
2022-10-31 19:36:44.119 - stderr> --------------------------^^^
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.141 - stdout> spark-sql> /* SELECT /*+ HINT() 4; */ SELECT 1;
2022-10-31 19:36:48.341 - stdout> 1
2022-10-31 19:36:48.341 - stderr> Time taken: 4.196 seconds, Fetched 1 row(s)
2022-10-31 19:36:48.352 - stdout> spark-sql> /* Here is a unclosed bracketed comment SELECT 1;
2022-10-31 19:36:48.361 - stderr>
2022-10-31 19:36:48.361 - stderr> null(line 1, pos 0)
```
I think maybe we might need to introduce new `SparkException` that cover the existing `ParseException` such as `SparkParseException` ??
So, can we keep it as is for now, and remove the duplicated message when `SparkParseException` is introduced ??
Can I create a JIRA and make a follow-up once we complete the other remaining error message improvements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #38447:
URL: https://github.com/apache/spark/pull/38447#discussion_r1012485332
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala:
##########
@@ -608,8 +608,12 @@ private[sql] object QueryParsingErrors extends QueryErrorsBase {
}
def unclosedBracketedCommentError(command: String, position: Origin): Throwable = {
- new ParseException(Some(command), "Unclosed bracketed comment", position, position,
- Some("_LEGACY_ERROR_TEMP_0055"))
+ new ParseException(
+ Some(command),
+ "Found an unclosed bracketed comment. Please, append */ at the end of the comment.",
Review Comment:
I think maybe If we don't specify the message here, then `null` is returned, so the `CliSuite.SPARK-37555: spark-sql should pass last unclosed comment to backend` failed as below:
```
CliSuite.SPARK-37555: spark-sql should pass last unclosed comment to backend
org.scalatest.exceptions.TestFailedException:
=======================
CliSuite failure output
=======================
Spark SQL CLI command line: ../../bin/spark-sql --master local --driver-java-options -Dderby.system.durability=test --conf spark.ui.enabled=false --hiveconf javax.jdo.option.ConnectionURL=jdbc:derby:;databaseName=/home/runner/work/spark/spark/target/tmp/spark-346cf558-8a95-43f1-b893-81f6a5571f3f;create=true --hiveconf hive.exec.scratchdir=/home/runner/work/spark/spark/target/tmp/spark-f108bccb-3f71-4854-aa70-c18ea721617c --hiveconf conf1=conftest --hiveconf conf2=1 --hiveconf hive.metastore.warehouse.dir=/home/runner/work/spark/spark/target/tmp/spark-86d39e14-55f9-437b-a676-7a5cabd58904
Exception: java.util.concurrent.TimeoutException: Futures timed out after [2 minutes]
Failed to capture next expected output "Found an unclosed bracketed comment." within 2 minutes.
2022-10-31 19:36:30.434 - stderr> Setting default log level to "WARN".
2022-10-31 19:36:30.434 - stderr> To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
2022-10-31 19:36:41.979 - stderr> Spark master: local, Application Id: local-1667270193279
2022-10-31 19:36:43.351 - stdout> spark-sql> /* SELECT /*+ HINT() 4; */;
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.119 - stderr> [PARSE_SYNTAX_ERROR] Syntax error at or near ';'(line 1, pos 26)
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.119 - stderr> == SQL ==
2022-10-31 19:36:44.119 - stderr> /* SELECT /*+ HINT() 4; */;
2022-10-31 19:36:44.119 - stderr> --------------------------^^^
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.141 - stdout> spark-sql> /* SELECT /*+ HINT() 4; */ SELECT 1;
2022-10-31 19:36:48.341 - stdout> 1
2022-10-31 19:36:48.341 - stderr> Time taken: 4.196 seconds, Fetched 1 row(s)
2022-10-31 19:36:48.352 - stdout> spark-sql> /* Here is a unclosed bracketed comment SELECT 1;
2022-10-31 19:36:48.361 - stderr>
2022-10-31 19:36:48.361 - stderr> null(line 1, pos 0)
```
I think maybe we might need to introduce new `SparkException` for `ParseException` such as `SparkParseException` ??
So, can we keep it as is for now, and remove the duplicated message when `SparkParseException` is introduced ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38447: [WIP][SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38447:
URL: https://github.com/apache/spark/pull/38447#discussion_r1009502328
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1418,7 +1418,7 @@
"It is not allowed to add database prefix `<database>` for the TEMPORARY view name."
]
},
- "_LEGACY_ERROR_TEMP_0055" : {
+ "UNCLOSED_BRACKETED_COMMENT" : {
Review Comment:
Don't think you can rename in place. Error class names should be sorted in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #38447:
URL: https://github.com/apache/spark/pull/38447#discussion_r1012485332
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala:
##########
@@ -608,8 +608,12 @@ private[sql] object QueryParsingErrors extends QueryErrorsBase {
}
def unclosedBracketedCommentError(command: String, position: Origin): Throwable = {
- new ParseException(Some(command), "Unclosed bracketed comment", position, position,
- Some("_LEGACY_ERROR_TEMP_0055"))
+ new ParseException(
+ Some(command),
+ "Found an unclosed bracketed comment. Please, append */ at the end of the comment.",
Review Comment:
I think maybe If we don't specify the message here, then `null` is returned so the `CliSuite.SPARK-37555: spark-sql should pass last unclosed comment to backend` failed as below:
```
CliSuite.SPARK-37555: spark-sql should pass last unclosed comment to backend
org.scalatest.exceptions.TestFailedException:
=======================
CliSuite failure output
=======================
Spark SQL CLI command line: ../../bin/spark-sql --master local --driver-java-options -Dderby.system.durability=test --conf spark.ui.enabled=false --hiveconf javax.jdo.option.ConnectionURL=jdbc:derby:;databaseName=/home/runner/work/spark/spark/target/tmp/spark-346cf558-8a95-43f1-b893-81f6a5571f3f;create=true --hiveconf hive.exec.scratchdir=/home/runner/work/spark/spark/target/tmp/spark-f108bccb-3f71-4854-aa70-c18ea721617c --hiveconf conf1=conftest --hiveconf conf2=1 --hiveconf hive.metastore.warehouse.dir=/home/runner/work/spark/spark/target/tmp/spark-86d39e14-55f9-437b-a676-7a5cabd58904
Exception: java.util.concurrent.TimeoutException: Futures timed out after [2 minutes]
Failed to capture next expected output "Found an unclosed bracketed comment." within 2 minutes.
2022-10-31 19:36:30.434 - stderr> Setting default log level to "WARN".
2022-10-31 19:36:30.434 - stderr> To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
2022-10-31 19:36:41.979 - stderr> Spark master: local, Application Id: local-1667270193279
2022-10-31 19:36:43.351 - stdout> spark-sql> /* SELECT /*+ HINT() 4; */;
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.119 - stderr> [PARSE_SYNTAX_ERROR] Syntax error at or near ';'(line 1, pos 26)
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.119 - stderr> == SQL ==
2022-10-31 19:36:44.119 - stderr> /* SELECT /*+ HINT() 4; */;
2022-10-31 19:36:44.119 - stderr> --------------------------^^^
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.141 - stdout> spark-sql> /* SELECT /*+ HINT() 4; */ SELECT 1;
2022-10-31 19:36:48.341 - stdout> 1
2022-10-31 19:36:48.341 - stderr> Time taken: 4.196 seconds, Fetched 1 row(s)
2022-10-31 19:36:48.352 - stdout> spark-sql> /* Here is a unclosed bracketed comment SELECT 1;
2022-10-31 19:36:48.361 - stderr>
2022-10-31 19:36:48.361 - stderr> null(line 1, pos 0)
```
I think maybe we might need to introduce new `SparkException` for `ParseException` such as `SparkParseException` ??
So, can we keep it as is for now, and remove the duplicated message when `SparkParseException` is introduced ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #38447:
URL: https://github.com/apache/spark/pull/38447#discussion_r1014998869
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala:
##########
@@ -608,8 +608,12 @@ private[sql] object QueryParsingErrors extends QueryErrorsBase {
}
def unclosedBracketedCommentError(command: String, position: Origin): Throwable = {
- new ParseException(Some(command), "Unclosed bracketed comment", position, position,
- Some("_LEGACY_ERROR_TEMP_0055"))
+ new ParseException(
+ Some(command),
+ "Found an unclosed bracketed comment. Please, append */ at the end of the comment.",
+ position,
+ position,
+ Some("UNCLOSED_BRACKETED_COMMENT"))
Review Comment:
Cool! Thanks for the suggestion 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38447:
URL: https://github.com/apache/spark/pull/38447#issuecomment-1306990491
+1, LGTM. Merging to master.
Thank you, @itholic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38447:
URL: https://github.com/apache/spark/pull/38447#discussion_r1013953353
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala:
##########
@@ -608,8 +608,12 @@ private[sql] object QueryParsingErrors extends QueryErrorsBase {
}
def unclosedBracketedCommentError(command: String, position: Origin): Throwable = {
- new ParseException(Some(command), "Unclosed bracketed comment", position, position,
- Some("_LEGACY_ERROR_TEMP_0055"))
+ new ParseException(
+ Some(command),
+ "Found an unclosed bracketed comment. Please, append */ at the end of the comment.",
+ position,
+ position,
+ Some("UNCLOSED_BRACKETED_COMMENT"))
Review Comment:
Could you replace this by:
```suggestion
new ParseException(
command = Some(command),
start = start,
stop = stop,
errorClass = "UNCLOSED_BRACKETED_COMMENT",
messageParameters = Map.empty)
```
and invoke via:
```scala
throw QueryParsingErrors.unclosedBracketedCommentError(
command = command,
start = Origin(Option(failedToken.getStartIndex)),
stop = Origin(Option(failedToken.getStopIndex)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #38447: [WIP][SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #38447:
URL: https://github.com/apache/spark/pull/38447#discussion_r1009610596
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1418,7 +1418,7 @@
"It is not allowed to add database prefix `<database>` for the TEMPORARY view name."
]
},
- "_LEGACY_ERROR_TEMP_0055" : {
+ "UNCLOSED_BRACKETED_COMMENT" : {
Review Comment:
Oops, my mistake. Thanks for the correction!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #38447:
URL: https://github.com/apache/spark/pull/38447#discussion_r1012485332
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala:
##########
@@ -608,8 +608,12 @@ private[sql] object QueryParsingErrors extends QueryErrorsBase {
}
def unclosedBracketedCommentError(command: String, position: Origin): Throwable = {
- new ParseException(Some(command), "Unclosed bracketed comment", position, position,
- Some("_LEGACY_ERROR_TEMP_0055"))
+ new ParseException(
+ Some(command),
+ "Found an unclosed bracketed comment. Please, append */ at the end of the comment.",
Review Comment:
I think maybe If we don't specify the message here, then `null` is returned, so the `CliSuite.SPARK-37555: spark-sql should pass last unclosed comment to backend` failed as below:
```
CliSuite.SPARK-37555: spark-sql should pass last unclosed comment to backend
org.scalatest.exceptions.TestFailedException:
=======================
CliSuite failure output
=======================
Spark SQL CLI command line: ../../bin/spark-sql --master local --driver-java-options -Dderby.system.durability=test --conf spark.ui.enabled=false --hiveconf javax.jdo.option.ConnectionURL=jdbc:derby:;databaseName=/home/runner/work/spark/spark/target/tmp/spark-346cf558-8a95-43f1-b893-81f6a5571f3f;create=true --hiveconf hive.exec.scratchdir=/home/runner/work/spark/spark/target/tmp/spark-f108bccb-3f71-4854-aa70-c18ea721617c --hiveconf conf1=conftest --hiveconf conf2=1 --hiveconf hive.metastore.warehouse.dir=/home/runner/work/spark/spark/target/tmp/spark-86d39e14-55f9-437b-a676-7a5cabd58904
Exception: java.util.concurrent.TimeoutException: Futures timed out after [2 minutes]
Failed to capture next expected output "Found an unclosed bracketed comment." within 2 minutes.
2022-10-31 19:36:30.434 - stderr> Setting default log level to "WARN".
2022-10-31 19:36:30.434 - stderr> To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
2022-10-31 19:36:41.979 - stderr> Spark master: local, Application Id: local-1667270193279
2022-10-31 19:36:43.351 - stdout> spark-sql> /* SELECT /*+ HINT() 4; */;
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.119 - stderr> [PARSE_SYNTAX_ERROR] Syntax error at or near ';'(line 1, pos 26)
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.119 - stderr> == SQL ==
2022-10-31 19:36:44.119 - stderr> /* SELECT /*+ HINT() 4; */;
2022-10-31 19:36:44.119 - stderr> --------------------------^^^
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.141 - stdout> spark-sql> /* SELECT /*+ HINT() 4; */ SELECT 1;
2022-10-31 19:36:48.341 - stdout> 1
2022-10-31 19:36:48.341 - stderr> Time taken: 4.196 seconds, Fetched 1 row(s)
2022-10-31 19:36:48.352 - stdout> spark-sql> /* Here is a unclosed bracketed comment SELECT 1;
2022-10-31 19:36:48.361 - stderr>
2022-10-31 19:36:48.361 - stderr> null(line 1, pos 0)
```
I think maybe we might need to introduce new `SparkException` that cover the existing `ParseException` such as `SparkParseException` ??
So, can we keep it as is for now, and remove the duplicated message when `SparkParseException` is introduced ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #38447: [SPARK-40973][SQL] Rename `_LEGACY_ERROR_TEMP_0055` to `UNCLOSED_BRACKETED_COMMENT`
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #38447:
URL: https://github.com/apache/spark/pull/38447#discussion_r1012485332
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala:
##########
@@ -608,8 +608,12 @@ private[sql] object QueryParsingErrors extends QueryErrorsBase {
}
def unclosedBracketedCommentError(command: String, position: Origin): Throwable = {
- new ParseException(Some(command), "Unclosed bracketed comment", position, position,
- Some("_LEGACY_ERROR_TEMP_0055"))
+ new ParseException(
+ Some(command),
+ "Found an unclosed bracketed comment. Please, append */ at the end of the comment.",
Review Comment:
I think maybe If we don't specify the message here, then `null` is returned, so the `CliSuite.SPARK-37555: spark-sql should pass last unclosed comment to backend` failed as below:
```
CliSuite.SPARK-37555: spark-sql should pass last unclosed comment to backend
org.scalatest.exceptions.TestFailedException:
=======================
CliSuite failure output
=======================
Spark SQL CLI command line: ../../bin/spark-sql --master local --driver-java-options -Dderby.system.durability=test --conf spark.ui.enabled=false --hiveconf javax.jdo.option.ConnectionURL=jdbc:derby:;databaseName=/home/runner/work/spark/spark/target/tmp/spark-346cf558-8a95-43f1-b893-81f6a5571f3f;create=true --hiveconf hive.exec.scratchdir=/home/runner/work/spark/spark/target/tmp/spark-f108bccb-3f71-4854-aa70-c18ea721617c --hiveconf conf1=conftest --hiveconf conf2=1 --hiveconf hive.metastore.warehouse.dir=/home/runner/work/spark/spark/target/tmp/spark-86d39e14-55f9-437b-a676-7a5cabd58904
Exception: java.util.concurrent.TimeoutException: Futures timed out after [2 minutes]
Failed to capture next expected output "Found an unclosed bracketed comment." within 2 minutes.
2022-10-31 19:36:30.434 - stderr> Setting default log level to "WARN".
2022-10-31 19:36:30.434 - stderr> To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
2022-10-31 19:36:41.979 - stderr> Spark master: local, Application Id: local-1667270193279
2022-10-31 19:36:43.351 - stdout> spark-sql> /* SELECT /*+ HINT() 4; */;
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.119 - stderr> [PARSE_SYNTAX_ERROR] Syntax error at or near ';'(line 1, pos 26)
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.119 - stderr> == SQL ==
2022-10-31 19:36:44.119 - stderr> /* SELECT /*+ HINT() 4; */;
2022-10-31 19:36:44.119 - stderr> --------------------------^^^
2022-10-31 19:36:44.119 - stderr>
2022-10-31 19:36:44.141 - stdout> spark-sql> /* SELECT /*+ HINT() 4; */ SELECT 1;
2022-10-31 19:36:48.341 - stdout> 1
2022-10-31 19:36:48.341 - stderr> Time taken: 4.196 seconds, Fetched 1 row(s)
2022-10-31 19:36:48.352 - stdout> spark-sql> /* Here is a unclosed bracketed comment SELECT 1;
2022-10-31 19:36:48.361 - stderr>
2022-10-31 19:36:48.361 - stderr> null(line 1, pos 0)
```
I think maybe we might need to introduce new `SparkException` can cover the existing `ParseException` such as `SparkParseException` ??
So, can we keep it as is for now, and remove the duplicated message when `SparkParseException` is introduced ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org