[GitHub] [cloudstack] rhtyd commented on a change in pull request #3331: api/server: Add option 'details' to listProjects and listAccounts

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #3331: api/server: Add option 'details' to listProjects and listAccounts
URL: https://github.com/apache/cloudstack/pull/3331#discussion_r287785901
 
 

 ##########
 File path: api/src/main/java/org/apache/cloudstack/api/command/user/account/ListAccountsCmd.java
 ##########
 @@ -55,6 +61,12 @@
     @Parameter(name = ApiConstants.STATE, type = CommandType.STRING, description = "list accounts by state. Valid states are enabled, disabled, and locked.")
     private String state;
 
+    @Parameter(name = ApiConstants.DETAILS,
+               type = CommandType.LIST,
+               collectionType = CommandType.STRING,
+               description = "comma separated list of account details requested, value can be a list of [ all, resource, min]")
+    private List<String> viewDetails;
 
 Review comment:
   details throughout CloudStack relates to an API arg that is of key:value map. Why not call something meaningful like `view` or verbosity etc?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services