You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/15 13:20:08 UTC
[GitHub] [pulsar] leizhiyuan opened a new pull request, #16078: fix: Prevent StackOverFlowException in SHARED subscription
leizhiyuan opened a new pull request, #16078:
URL: https://github.com/apache/pulsar/pull/16078
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #16074
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on pull request #16078: fix: Prevent StackOverFlowException in SHARED subscription
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on PR #16078:
URL: https://github.com/apache/pulsar/pull/16078#issuecomment-1157659047
> Could you provide more analysis about how does it happen?
we found this in our production env. when all consumers disconnected, and then connect again, it may occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #16078: fix: Prevent StackOverFlowException in SHARED subscription
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #16078:
URL: https://github.com/apache/pulsar/pull/16078#issuecomment-1161940203
I found a similar fix just now, see https://github.com/apache/pulsar/pull/14121. Could you also share your point on this PR? @eolivelli
Actually I'm a little confused in which case should `readMoreEntries` be called in `BrokerService`'s executor. /cc @lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16078: fix: Prevent StackOverFlowException in SHARED subscription
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16078:
URL: https://github.com/apache/pulsar/pull/16078#issuecomment-1192108689
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #16078: fix: Prevent StackOverFlowException in SHARED subscription
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #16078:
URL: https://github.com/apache/pulsar/pull/16078#issuecomment-1157505053
Could you provide more analysis about how does it happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on pull request #16078: fix: Prevent StackOverFlowException in SHARED subscription
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on PR #16078:
URL: https://github.com/apache/pulsar/pull/16078#issuecomment-1157658189
> #16074
if depth is exceeded, we dispatch it to another thread,maybe it will fail again in another thread.
maybe we should abort the invoke when reaching up to the max depth?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org