You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/15 08:47:36 UTC
[GitHub] [pulsar] leizhiyuan opened a new pull request, #17095: fix: bundle-data metadata leak because of bundlestats was not clean
leizhiyuan opened a new pull request, #17095:
URL: https://github.com/apache/pulsar/pull/17095
Master Issue: #17087
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on PR #17095:
URL: https://github.com/apache/pulsar/pull/17095#issuecomment-1312274812
> [fix][broker]bundle-data metadata leak because of bundlestats was not clean #17316
https://github.com/apache/pulsar/pull/17316
I have pushed before, please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on PR #17095:
URL: https://github.com/apache/pulsar/pull/17095#issuecomment-1236477022
> Can you help open a new PR to branch-2.10? There are a lot conflict when cherry-pick directly. @leizhiyuan
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #17095:
URL: https://github.com/apache/pulsar/pull/17095#issuecomment-1227049704
Hi, @leizhiyuan
Would you like to push a PR to branch-2.9 to fix this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17095:
URL: https://github.com/apache/pulsar/pull/17095#issuecomment-1214769247
@leizhiyuan Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on PR #17095:
URL: https://github.com/apache/pulsar/pull/17095#issuecomment-1318514718
@leizhiyuan hi, I move this PR to `release/2.9.5`, if you have any questions, please ping me. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17095:
URL: https://github.com/apache/pulsar/pull/17095#issuecomment-1343730171
Cherry-pick PRs failed and stale. Close them and label this PR with `release/2.10.3`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin merged pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
gaozhangmin merged PR #17095:
URL: https://github.com/apache/pulsar/pull/17095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #17095:
URL: https://github.com/apache/pulsar/pull/17095#issuecomment-1236337681
Can you help open a new PR to branch-2.10? There are a lot conflict when cherry-pick directly. @leizhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on PR #17095:
URL: https://github.com/apache/pulsar/pull/17095#issuecomment-1312478152
> > [fix][broker]bundle-data metadata leak because of bundlestats was not clean #17316
>
> #17316
>
> I have pushed before, please take a look
seem the test failed, could you please fix this test? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #17095:
URL: https://github.com/apache/pulsar/pull/17095#issuecomment-1256903753
`release/2.10.3` moved to https://github.com/apache/pulsar/pull/17463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on PR #17095:
URL: https://github.com/apache/pulsar/pull/17095#issuecomment-1311312378
Hi @leizhiyuan
Could you help cherry-pick this PR to branch-2.9? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #17095: fix: bundle-data metadata leak because of bundlestats was not clean
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #17095:
URL: https://github.com/apache/pulsar/pull/17095#issuecomment-1610272083
As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org