You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/09 10:10:56 UTC
[GitHub] [nifi] nandorsoma commented on a diff in pull request #6225: NIFI-10251 Add v5 protocol support for existing MQTT processors
nandorsoma commented on code in PR #6225:
URL: https://github.com/apache/nifi/pull/6225#discussion_r941155396
##########
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java:
##########
@@ -199,16 +198,13 @@ public ValidationResult validate(String subject, String input, ValidationContext
.defaultValue(ALLOWABLE_VALUE_CLEAN_SESSION_TRUE.getValue())
.build();
- public static final PropertyDescriptor PROP_MQTT_VERSION = new PropertyDescriptor.Builder()
- .name("MQTT Specification Version")
- .description("The MQTT specification version when connecting with the broker. See the allowable value descriptions for more details.")
- .allowableValues(
- ALLOWABLE_VALUE_MQTT_VERSION_AUTO,
- ALLOWABLE_VALUE_MQTT_VERSION_311,
- ALLOWABLE_VALUE_MQTT_VERSION_310
- )
- .defaultValue(ALLOWABLE_VALUE_MQTT_VERSION_AUTO.getValue())
- .required(true)
+ public static final PropertyDescriptor PROP_SESSION_EXPIRY_INTERVAL = new PropertyDescriptor.Builder()
+ .name("Session Expiry Interval")
+ .description("After this interval the broker will expire the client and clear the session state.")
+ .addValidator(StandardValidators.NON_NEGATIVE_LONG_VALIDATOR)
+ .dependsOn(PROP_MQTT_VERSION, ALLOWABLE_VALUE_MQTT_VERSION_500)
+ .dependsOn(PROP_CLEAN_SESSION, ALLOWABLE_VALUE_CLEAN_SESSION_FALSE)
+ .defaultValue(Long.toString(SESSION_EXPIRY_INTERVAL_IN_SECONDS))
.build();
Review Comment:
Thanks for the suggestion @tpalfy ! I like this solution however there are similar properties in the processor where just numbers without units were used. I think it is better to stick to the original version to avoid mixing the input types. Nevertheless I've added a hint to the name of the property to match the other properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org