[GitHub] seanyinx commented on a change in pull request #114: SCB-227 stop sub tx from running when global tx failed

[GitBox <gi...@apache.org>]

seanyinx commented on a change in pull request #114: SCB-227 stop sub tx from running when global tx failed
URL: https://github.com/apache/incubator-servicecomb-saga/pull/114#discussion_r161416991
 
 

 ##########
 File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/TxConsistentService.java
 ##########
 @@ -100,4 +106,8 @@ private boolean isGlobalTxAborted(TxEvent event) {
   private boolean isTxEndedEvent(TxEvent event) {
     return TxEndedEvent.name().equals(event.type());
   }
+
+  private boolean isInvalidTxStarted(TxEvent event) {
 
 Review comment:
   probably inlining this method is more readable

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services