You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/08/02 07:15:19 UTC
Review Request 71232: Renamed cmake parameter for parallel test
execution.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71232/
-----------------------------------------------------------
Review request for mesos, Benno Evers and Till Toenshoff.
Bugs: MESOS-6382
https://issues.apache.org/jira/browse/MESOS-6382
Repository: mesos
Description
-------
The Jenkins setup (which uses `support/docker-build.sh` under the
covers) is parameterized with the `CONFIGURATION` environment variable.
While in we pass configure-style flags for both autotools and cmake
builds to it in the Jenkins
configuration, the script performs transformations so that
configure-style flags are transformed to cmake-style (replace `_` with
`-`, uppercase flags, replace `--` with `-D`).
We disable parallel test execution in Jenkins by passing
`--disable-parallel-test-execution` which with the transformations in
`support/docker-build.sh` leads to a cmake arg
`-DDISABLE_PARALLEL_TEST_EXECUTION=1`. This patch renames the cmake arg
from a default enabled `ENABLE_PARALLEL_TEST_EXECUTION` to a default
disabled `DISABLE_PARALLEL_TEST_EXECUTION` to support this workflow.
Diffs
-----
cmake/MesosConfigure.cmake ca8d406e1be9d6ab50c6c9dc4d2de97189b17b9a
Diff: https://reviews.apache.org/r/71232/diff/1/
Testing
-------
Tested ctest behavior with both the new flag enabled and disabled.
Thanks,
Benjamin Bannier
Re: Review Request 71232: Renamed cmake parameter for parallel test
execution.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71232/#review217050
-----------------------------------------------------------
Fix it, then Ship it!
cmake/MesosConfigure.cmake
Line 49 (original), 49 (patched)
<https://reviews.apache.org/r/71232/#comment304271>
s/no/not/
- Till Toenshoff
On Aug. 2, 2019, 7:15 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71232/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2019, 7:15 a.m.)
>
>
> Review request for mesos, Benno Evers and Till Toenshoff.
>
>
> Bugs: MESOS-6382
> https://issues.apache.org/jira/browse/MESOS-6382
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Jenkins setup (which uses `support/docker-build.sh` under the
> covers) is parameterized with the `CONFIGURATION` environment variable.
> While in we pass configure-style flags for both autotools and cmake
> builds to it in the Jenkins
> configuration, the script performs transformations so that
> configure-style flags are transformed to cmake-style (replace `_` with
> `-`, uppercase flags, replace `--` with `-D`).
>
> We disable parallel test execution in Jenkins by passing
> `--disable-parallel-test-execution` which with the transformations in
> `support/docker-build.sh` leads to a cmake arg
> `-DDISABLE_PARALLEL_TEST_EXECUTION=1`. This patch renames the cmake arg
> from a default enabled `ENABLE_PARALLEL_TEST_EXECUTION` to a default
> disabled `DISABLE_PARALLEL_TEST_EXECUTION` to support this workflow.
>
>
> Diffs
> -----
>
> cmake/MesosConfigure.cmake ca8d406e1be9d6ab50c6c9dc4d2de97189b17b9a
>
>
> Diff: https://reviews.apache.org/r/71232/diff/1/
>
>
> Testing
> -------
>
> Tested ctest behavior with both the new flag enabled and disabled.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71232: Renamed cmake parameter for parallel test
execution.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71232/#review217051
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71232]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 2, 2019, 12:15 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71232/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2019, 12:15 a.m.)
>
>
> Review request for mesos, Benno Evers and Till Toenshoff.
>
>
> Bugs: MESOS-6382
> https://issues.apache.org/jira/browse/MESOS-6382
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Jenkins setup (which uses `support/docker-build.sh` under the
> covers) is parameterized with the `CONFIGURATION` environment variable.
> While in we pass configure-style flags for both autotools and cmake
> builds to it in the Jenkins
> configuration, the script performs transformations so that
> configure-style flags are transformed to cmake-style (replace `_` with
> `-`, uppercase flags, replace `--` with `-D`).
>
> We disable parallel test execution in Jenkins by passing
> `--disable-parallel-test-execution` which with the transformations in
> `support/docker-build.sh` leads to a cmake arg
> `-DDISABLE_PARALLEL_TEST_EXECUTION=1`. This patch renames the cmake arg
> from a default enabled `ENABLE_PARALLEL_TEST_EXECUTION` to a default
> disabled `DISABLE_PARALLEL_TEST_EXECUTION` to support this workflow.
>
>
> Diffs
> -----
>
> cmake/MesosConfigure.cmake ca8d406e1be9d6ab50c6c9dc4d2de97189b17b9a
>
>
> Diff: https://reviews.apache.org/r/71232/diff/2/
>
>
> Testing
> -------
>
> Tested ctest behavior with both the new flag enabled and disabled.
>
>
> Thanks,
>
> Benjamin Bannier
>
>