You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by wgtmac <gi...@git.apache.org> on 2017/05/02 05:11:51 UTC

[GitHub] orc pull request #111: ORC-173: [C++] Expose Indexes as API

Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/111#discussion_r114249399
  
    --- Diff: c++/src/Statistics.hh ---
    @@ -605,6 +676,43 @@ namespace orc {
         }
       };
     
    +  class StripeStatisticsImpl: public StripeStatistics {
    +  private:
    +    std::unique_ptr<StatisticsImpl> columnStats;
    +    std::vector<std::vector<std::unique_ptr<const ColumnStatistics> > > rowIndexStats;
    --- End diff --
    
    Similar to my previous comment in ORC-87. If we need to be compatible with older C++ standards, this line may not work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---