You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hector Acosta (Code Review)" <ge...@cloudera.org> on 2019/03/22 18:09:08 UTC

[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws

Hello Lars Volker, Laszlo Gaal, Jim Apple, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12727

to look at the new patch set (#5).

Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws
......................................................................

Use 'wget http://169.254.169.254/' to determine if we're running in aws

https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html
lists the above endpoint as the first choice.

In my running instance `dmidecode -s bios-version` prints out:
1.0

dmidecode --string system-uuid|grep ^ec2 seems like a valid alternative
here.

I removed the 'grep' assertions since it's possible that images may have
already configured ntp here.

Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205
---
M bin/bootstrap_system.sh
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/12727/5
-- 
To view, visit http://gerrit.cloudera.org:8080/12727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205
Gerrit-Change-Number: 12727
Gerrit-PatchSet: 5
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>