You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/22 14:04:21 UTC
[GitHub] [flink] dawidwys commented on a change in pull request #10925:
[FLINK-15690][core][configuration] Enable configuring ExecutionConfig &
CheckpointConfig from flink-conf.yaml
dawidwys commented on a change in pull request #10925: [FLINK-15690][core][configuration] Enable configuring ExecutionConfig & CheckpointConfig from flink-conf.yaml
URL: https://github.com/apache/flink/pull/10925#discussion_r369576607
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java
##########
@@ -183,6 +187,33 @@ public static void writeFileInfoToConfig(String name, DistributedCacheEntry e, C
return cacheFiles.entrySet();
}
+ /**
Review comment:
Those changes are here because I moved the parsing logic of the `CachedFiles` from `StreamExecutionEnvironment` here so I can reuse it in both `ExecutionEnvironment` & `StreamExecutionEnvironment`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services