You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ma...@apache.org on 2015/09/03 17:53:03 UTC
ios commit: CB-8365 Add NSInteger,
NSUInteger factory methods to CDVPluginResult
Repository: cordova-ios
Updated Branches:
refs/heads/master ef355b334 -> 70cb400bb
CB-8365 Add NSInteger, NSUInteger factory methods to CDVPluginResult
Project: http://git-wip-us.apache.org/repos/asf/cordova-ios/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/70cb400b
Tree: http://git-wip-us.apache.org/repos/asf/cordova-ios/tree/70cb400b
Diff: http://git-wip-us.apache.org/repos/asf/cordova-ios/diff/70cb400b
Branch: refs/heads/master
Commit: 70cb400bb3885d3bde4e2005c5d4a6f1839d8b7b
Parents: ef355b3
Author: Simon MacDonald <si...@gmail.com>
Authored: Thu Sep 3 11:52:58 2015 -0400
Committer: Simon MacDonald <si...@gmail.com>
Committed: Thu Sep 3 11:52:58 2015 -0400
----------------------------------------------------------------------
CordovaLib/Classes/Public/CDVPluginResult.h | 2 ++
CordovaLib/Classes/Public/CDVPluginResult.m | 10 ++++++++++
guides/API changes in 4.0.md | 9 +++++++++
.../CDVPluginResultJSONSerializationTests.m | 16 ++++++++++++++++
4 files changed, 37 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/70cb400b/CordovaLib/Classes/Public/CDVPluginResult.h
----------------------------------------------------------------------
diff --git a/CordovaLib/Classes/Public/CDVPluginResult.h b/CordovaLib/Classes/Public/CDVPluginResult.h
index 7377b12..56b8c23 100644
--- a/CordovaLib/Classes/Public/CDVPluginResult.h
+++ b/CordovaLib/Classes/Public/CDVPluginResult.h
@@ -47,6 +47,8 @@ typedef enum {
+ (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsString:(NSString*)theMessage;
+ (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsArray:(NSArray*)theMessage;
+ (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsInt:(int)theMessage;
++ (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsNSInteger:(NSInteger)theMessage;
++ (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsNSUInteger:(NSUInteger)theMessage;
+ (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsDouble:(double)theMessage;
+ (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsBool:(BOOL)theMessage;
+ (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsDictionary:(NSDictionary*)theMessage;
http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/70cb400b/CordovaLib/Classes/Public/CDVPluginResult.m
----------------------------------------------------------------------
diff --git a/CordovaLib/Classes/Public/CDVPluginResult.m b/CordovaLib/Classes/Public/CDVPluginResult.m
index b7a185d..3521e6d 100644
--- a/CordovaLib/Classes/Public/CDVPluginResult.m
+++ b/CordovaLib/Classes/Public/CDVPluginResult.m
@@ -113,6 +113,16 @@ id messageFromMultipart(NSArray* theMessages)
return [[self alloc] initWithStatus:statusOrdinal message:[NSNumber numberWithInt:theMessage]];
}
++ (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsNSInteger:(NSInteger)theMessage
+{
+ return [[self alloc] initWithStatus:statusOrdinal message:[NSNumber numberWithInteger:theMessage]];
+}
+
++ (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsNSUInteger:(NSUInteger)theMessage
+{
+ return [[self alloc] initWithStatus:statusOrdinal message:[NSNumber numberWithUnsignedInteger:theMessage]];
+}
+
+ (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsDouble:(double)theMessage
{
return [[self alloc] initWithStatus:statusOrdinal message:[NSNumber numberWithDouble:theMessage]];
http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/70cb400b/guides/API changes in 4.0.md
----------------------------------------------------------------------
diff --git a/guides/API changes in 4.0.md b/guides/API changes in 4.0.md
index 0f2c0f2..e54c88a 100644
--- a/guides/API changes in 4.0.md
+++ b/guides/API changes in 4.0.md
@@ -79,3 +79,12 @@ Methods:
- (BOOL)shouldAllowRequestForURL:(NSURL *)url
- (BOOL)shouldAllowNavigationToURL:(NSURL *)url
- (BOOL)shouldOpenExternalURL:(NSURL *)url
+
+## CDVPluginResult.h
+
+### Added:
+
+Methods:
+
+ + (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsNSInteger:(NSInteger)theMessage;
+ + (CDVPluginResult*)resultWithStatus:(CDVCommandStatus)statusOrdinal messageAsNSUInteger:(NSUInteger)theMessage;
http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/70cb400b/tests/CordovaLibTests/CDVPluginResultJSONSerializationTests.m
----------------------------------------------------------------------
diff --git a/tests/CordovaLibTests/CDVPluginResultJSONSerializationTests.m b/tests/CordovaLibTests/CDVPluginResultJSONSerializationTests.m
index fbecaaa..dacb196 100644
--- a/tests/CordovaLibTests/CDVPluginResultJSONSerializationTests.m
+++ b/tests/CordovaLibTests/CDVPluginResultJSONSerializationTests.m
@@ -36,6 +36,22 @@
XCTAssertTrue([[NSNumber numberWithInt:val] isEqual:[[result argumentsAsJSON] cdv_JSONFragment]]);
}
+- (void)testSerializingMessageAsNSNumber
+{
+ NSInteger val = 5;
+ CDVPluginResult* result = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsNSInteger:val];
+
+ XCTAssertTrue([[NSNumber numberWithInteger:val] isEqual:[[result argumentsAsJSON] cdv_JSONFragment]]);
+}
+
+- (void)testSerializingMessageAsNSUNumber
+{
+ NSUInteger val = 5;
+ CDVPluginResult* result = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsNSUInteger:val];
+
+ XCTAssertTrue([[NSNumber numberWithUnsignedInteger:val] isEqual:[[result argumentsAsJSON] cdv_JSONFragment]]);
+}
+
- (void)testSerializingMessageAsDouble
{
double val = 5.5;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org