You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "peter royal (JIRA)" <ji...@apache.org> on 2007/09/02 18:55:19 UTC

[jira] Created: (DIRMINA-430) SocketSessionImpl.getScheduledWriteBytes slows with size of queue

SocketSessionImpl.getScheduledWriteBytes slows with size of queue
-----------------------------------------------------------------

                 Key: DIRMINA-430
                 URL: https://issues.apache.org/jira/browse/DIRMINA-430
             Project: MINA
          Issue Type: Improvement
          Components: Core
    Affects Versions: 1.1.2
            Reporter: peter royal
            Assignee: peter royal
             Fix For: 1.1.3, 2.0.0-M1


Whenever you call SocketSessionImpl.getScheduledWriteBytes, it manually tallies the size of the queue. 

This is inefficient when the queue has a decent number of outstanding requests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRMINA-430) IoSession.getScheduledWriteBytes() slows with size of queue

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trustin Lee updated DIRMINA-430:
--------------------------------

          Component/s: Transport
    Affects Version/s: 1.0.5
        Fix Version/s:     (was: 2.0.0-M1)
                       1.0.6
              Summary: IoSession.getScheduledWriteBytes() slows with size of queue  (was: SocketSessionImpl.getScheduledWriteBytes slows with size of queue)

Let me fix it in 1.0, too.

> IoSession.getScheduledWriteBytes() slows with size of queue
> -----------------------------------------------------------
>
>                 Key: DIRMINA-430
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-430
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core, Transport
>    Affects Versions: 1.0.5, 1.1.2
>            Reporter: peter royal
>            Assignee: peter royal
>             Fix For: 1.0.6, 1.1.3
>
>
> Whenever you call SocketSessionImpl.getScheduledWriteBytes, it manually tallies the size of the queue. 
> This is inefficient when the queue has a decent number of outstanding requests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRMINA-430) SocketSessionImpl.getScheduledWriteBytes slows with size of queue

Posted by "peter royal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

peter royal closed DIRMINA-430.
-------------------------------

    Resolution: Fixed

Fixed in 1.1 and trunk. As it uses features of java5 to provide the fix, users of 1.0 should upgrade to make use of this performance enhancement.

> SocketSessionImpl.getScheduledWriteBytes slows with size of queue
> -----------------------------------------------------------------
>
>                 Key: DIRMINA-430
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-430
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.2
>            Reporter: peter royal
>            Assignee: peter royal
>             Fix For: 1.1.3, 2.0.0-M1
>
>
> Whenever you call SocketSessionImpl.getScheduledWriteBytes, it manually tallies the size of the queue. 
> This is inefficient when the queue has a decent number of outstanding requests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-430) SocketSessionImpl.getScheduledWriteBytes slows with size of queue

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524410 ] 

Trustin Lee commented on DIRMINA-430:
-------------------------------------

It also should be fixed in 1.0 branch and in trunk.

> SocketSessionImpl.getScheduledWriteBytes slows with size of queue
> -----------------------------------------------------------------
>
>                 Key: DIRMINA-430
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-430
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.2
>            Reporter: peter royal
>            Assignee: peter royal
>             Fix For: 1.1.3, 2.0.0-M1
>
>
> Whenever you call SocketSessionImpl.getScheduledWriteBytes, it manually tallies the size of the queue. 
> This is inefficient when the queue has a decent number of outstanding requests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (DIRMINA-430) SocketSessionImpl.getScheduledWriteBytes slows with size of queue

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trustin Lee reopened DIRMINA-430:
---------------------------------


Datagram transport also seems to be affected by this issue. Let's fix it either.

> SocketSessionImpl.getScheduledWriteBytes slows with size of queue
> -----------------------------------------------------------------
>
>                 Key: DIRMINA-430
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-430
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core, Transport
>    Affects Versions: 1.0.5, 1.1.2
>            Reporter: peter royal
>            Assignee: peter royal
>             Fix For: 1.0.6, 1.1.3
>
>
> Whenever you call SocketSessionImpl.getScheduledWriteBytes, it manually tallies the size of the queue. 
> This is inefficient when the queue has a decent number of outstanding requests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-430) SocketSessionImpl.getScheduledWriteBytes slows with size of queue

Posted by "peter royal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524366 ] 

peter royal commented on DIRMINA-430:
-------------------------------------

Fixed in 1.1 branch, need to determine if trunk needs fix and apply there.

> SocketSessionImpl.getScheduledWriteBytes slows with size of queue
> -----------------------------------------------------------------
>
>                 Key: DIRMINA-430
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-430
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.2
>            Reporter: peter royal
>            Assignee: peter royal
>             Fix For: 1.1.3, 2.0.0-M1
>
>
> Whenever you call SocketSessionImpl.getScheduledWriteBytes, it manually tallies the size of the queue. 
> This is inefficient when the queue has a decent number of outstanding requests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DIRMINA-430) IoSession.getScheduledWriteBytes() slows with size of queue

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trustin Lee resolved DIRMINA-430.
---------------------------------

    Resolution: Fixed

Peter, please confirm I didn't break anything. :)

> IoSession.getScheduledWriteBytes() slows with size of queue
> -----------------------------------------------------------
>
>                 Key: DIRMINA-430
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-430
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core, Transport
>    Affects Versions: 1.0.5, 1.1.2
>            Reporter: peter royal
>            Assignee: peter royal
>             Fix For: 1.0.6, 1.1.3
>
>
> Whenever you call SocketSessionImpl.getScheduledWriteBytes, it manually tallies the size of the queue. 
> This is inefficient when the queue has a decent number of outstanding requests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRMINA-430) IoSession.getScheduledWriteBytes() slows with size of queue

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny closed DIRMINA-430.
-------------------------------------


> IoSession.getScheduledWriteBytes() slows with size of queue
> -----------------------------------------------------------
>
>                 Key: DIRMINA-430
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-430
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core, Transport
>    Affects Versions: 1.0.5, 1.1.2
>            Reporter: peter royal
>            Assignee: peter royal
>             Fix For: 1.0.6, 1.1.3
>
>
> Whenever you call SocketSessionImpl.getScheduledWriteBytes, it manually tallies the size of the queue. 
> This is inefficient when the queue has a decent number of outstanding requests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.