You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/07 00:34:30 UTC
[GitHub] [arrow] kou opened a new pull request, #34947: GH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions
kou opened a new pull request, #34947:
URL: https://github.com/apache/arrow/pull/34947
### Rationale for this change
We can remove these omissions with the existing APIs.
### What changes are included in this PR?
Implement omitted tests with the existing APIs.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34947: GH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34947:
URL: https://github.com/apache/arrow/pull/34947#issuecomment-1500809047
Benchmark runs are scheduled for baseline = 4cbaa53f5c8745a54b6b8d6f34973b0342c53093 and contender = 7526df9ad97219cc44f9b460887405f2b0e86fd4. 7526df9ad97219cc44f9b460887405f2b0e86fd4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0d049b7bad484f33a15b10deda1684e4...f62c55f110e743db94580c591ea34fed/)
[Finished :arrow_down:1.51% :arrow_up:0.92%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5c206a2cd639469c982fefe9fb282d62...f92813d49f624ecca6dc064f65d00da3/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/620262abcc1544e4b7c0c5e363aece37...1b8a1249106c41439ae6790f4bde2439/)
[Finished :arrow_down:1.48% :arrow_up:1.02%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e2827f23fda845a1818a4fd17acf0d74...5965cf2abe5649cfa0cef11d6d9a4082/)
Buildkite builds:
[Finished] [`7526df9a` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2653)
[Finished] [`7526df9a` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2686)
[Finished] [`7526df9a` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2651)
[Finished] [`7526df9a` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2677)
[Finished] [`4cbaa53f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2652)
[Finished] [`4cbaa53f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2685)
[Finished] [`4cbaa53f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2650)
[Finished] [`4cbaa53f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2676)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34947: GH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34947:
URL: https://github.com/apache/arrow/pull/34947#issuecomment-1499859501
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34947: GH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34947:
URL: https://github.com/apache/arrow/pull/34947#issuecomment-1499792388
:warning: GitHub issue #34946 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34947: GH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34947:
URL: https://github.com/apache/arrow/pull/34947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34947: GH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34947:
URL: https://github.com/apache/arrow/pull/34947#issuecomment-1499792372
* Closes: #34946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org