You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@shindig.apache.org by "Jesse Ciancetta (JIRA)" <ji...@apache.org> on 2010/08/17 22:10:30 UTC

[jira] Created: (SHINDIG-1411) CSS rewriter doesnt take container into account when rewriting embedded URL's

CSS rewriter doesnt take container into account when rewriting embedded URL's
-----------------------------------------------------------------------------

                 Key: SHINDIG-1411
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1411
             Project: Shindig
          Issue Type: Bug
          Components: Java
    Affects Versions: 2.0.0-RC2
            Reporter: Jesse Ciancetta


I ran into a container configuration related issue while testing out RC2, which is that the CSS rewriter doesn't seem to be taking the container into account when rewriting embedded URL's -- it always uses the default container configuration which ends up giving me invalid proxy URL's in my rewritten CSS.  This appears to be due to the fact that the CssResponseRewriter uses the DomWalker.makeGadget method to create a Gadget instance to pass to the ProxyUriManager.ProxyUri constructor, but the GadgetContext inside that Gadget instance doesnt have the container set, which makes code that runs later in the ProxyUriManager to generate the proxy URL use the default container configuration instead of my custom container configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SHINDIG-1411) CSS rewriter doesnt take container into account when rewriting embedded URL's

Posted by "Jesse Ciancetta (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/SHINDIG-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Ciancetta updated SHINDIG-1411:
-------------------------------------

    Attachment: CSSRewriterPatch.patch

I was able to come up with a patch to work around this issue, but I'm not sure if its the best way to go about it...  There is a lot of code around the whole gadget rewriting process and I definitely don't have my head wrapped around all of it -- but I thought I'd take a crack at it anyway, if for nothing else to at least highlight where the issue is occurring.  The two major changes I made were to add another parameter to the DomWalker.makeGadget method for the container, and passing the container down through the call stack in the CssResponseRewriter.  For any other usages of the affected classes which broke -- if there was an obvious place to pull the container from (like a Gadget instance) I used it -- otherwise I just passed in null to trigger the default behavior (which is to return the default container).

> CSS rewriter doesnt take container into account when rewriting embedded URL's
> -----------------------------------------------------------------------------
>
>                 Key: SHINDIG-1411
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1411
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.0-RC2
>            Reporter: Jesse Ciancetta
>         Attachments: CSSRewriterPatch.patch
>
>
> I ran into a container configuration related issue while testing out RC2, which is that the CSS rewriter doesn't seem to be taking the container into account when rewriting embedded URL's -- it always uses the default container configuration which ends up giving me invalid proxy URL's in my rewritten CSS.  This appears to be due to the fact that the CssResponseRewriter uses the DomWalker.makeGadget method to create a Gadget instance to pass to the ProxyUriManager.ProxyUri constructor, but the GadgetContext inside that Gadget instance doesnt have the container set, which makes code that runs later in the ProxyUriManager to generate the proxy URL use the default container configuration instead of my custom container configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SHINDIG-1411) CSS rewriter doesnt take container into account when rewriting embedded URL's

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/SHINDIG-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-1411.
-----------------------------------

    Fix Version/s: 2.0.0
       Resolution: Fixed

patch was applied


> CSS rewriter doesnt take container into account when rewriting embedded URL's
> -----------------------------------------------------------------------------
>
>                 Key: SHINDIG-1411
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1411
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.0-RC2
>            Reporter: Jesse Ciancetta
>             Fix For: 2.0.0
>
>         Attachments: CSSRewriterPatch.patch
>
>
> I ran into a container configuration related issue while testing out RC2, which is that the CSS rewriter doesn't seem to be taking the container into account when rewriting embedded URL's -- it always uses the default container configuration which ends up giving me invalid proxy URL's in my rewritten CSS.  This appears to be due to the fact that the CssResponseRewriter uses the DomWalker.makeGadget method to create a Gadget instance to pass to the ProxyUriManager.ProxyUri constructor, but the GadgetContext inside that Gadget instance doesnt have the container set, which makes code that runs later in the ProxyUriManager to generate the proxy URL use the default container configuration instead of my custom container configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SHINDIG-1411) CSS rewriter doesnt take container into account when rewriting embedded URL's

Posted by "Gagandeep Singh (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/SHINDIG-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900974#action_12900974 ] 

Gagandeep Singh commented on SHINDIG-1411:
------------------------------------------

Codereview uploaded : http://codereview.appspot.com/2004042/

> CSS rewriter doesnt take container into account when rewriting embedded URL's
> -----------------------------------------------------------------------------
>
>                 Key: SHINDIG-1411
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1411
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.0-RC2
>            Reporter: Jesse Ciancetta
>         Attachments: CSSRewriterPatch.patch
>
>
> I ran into a container configuration related issue while testing out RC2, which is that the CSS rewriter doesn't seem to be taking the container into account when rewriting embedded URL's -- it always uses the default container configuration which ends up giving me invalid proxy URL's in my rewritten CSS.  This appears to be due to the fact that the CssResponseRewriter uses the DomWalker.makeGadget method to create a Gadget instance to pass to the ProxyUriManager.ProxyUri constructor, but the GadgetContext inside that Gadget instance doesnt have the container set, which makes code that runs later in the ProxyUriManager to generate the proxy URL use the default container configuration instead of my custom container configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.