[GitHub] [hive] devaspatikrishnatri commented on a diff in pull request #3996: HIVE-26999:Upgrade MySQL Connector Java due to security CVE

["devaspatikrishnatri (via GitHub)" <gi...@apache.org>]

devaspatikrishnatri commented on code in PR #3996:
URL: https://github.com/apache/hive/pull/3996#discussion_r1127788514


##########
standalone-metastore/pom.xml:
##########
@@ -365,8 +365,8 @@
         <optional>true</optional>
       </dependency>
       <dependency>
-        <groupId>mysql</groupId>
-        <artifactId>mysql-connector-java</artifactId>
+        <groupId>com.mysql</groupId>

Review Comment:
   We are not switching to a new library, the old one used to relocate to this mysqlconnecotr/j version.
   The my-sql-connector for 8.0.31 contains a relocation GAV to my-sql-connector/j 8.0.31
    
   original POM:
   https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.31/mysql-connector-java-8.0.31.pom
   
   and i had already attached the depedency tree in the apache jira for this change, no mention of mysql-connector-java is there.



##########
standalone-metastore/pom.xml:
##########
@@ -365,8 +365,8 @@
         <optional>true</optional>
       </dependency>
       <dependency>
-        <groupId>mysql</groupId>
-        <artifactId>mysql-connector-java</artifactId>
+        <groupId>com.mysql</groupId>

Review Comment:
   hope this is okay..?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org