You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/09/29 19:30:06 UTC
[GitHub] [phoenix] tkhurana commented on a change in pull request #897: PHOENIX-6160 Simplifying concurrent mutation handling for global Indexes
tkhurana commented on a change in pull request #897:
URL: https://github.com/apache/phoenix/pull/897#discussion_r496987773
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
##########
@@ -117,12 +118,15 @@
* Class to represent pending data table rows
*/
private static class PendingRow {
- private boolean concurrent = false;
private long count = 1;
+ private BatchMutateContext lastContext;
- public void add() {
+ PendingRow(BatchMutateContext context) {
+ lastContext = context;
Review comment:
slightly cleaner if we can initialize the count to 1 in the constructor itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org