Re: [PATCH] add support for svnrdump to svn-backup-dumps.py

[Masaru Tsuchiyama <m....@gmail.com>]

Ben Reser wrote:
> On 8/18/13 5:34 AM, Daniel Shahaf wrote:
>> Haven't looked at the rest of the patch, perhaps Ben will as he reviewed
>> an earlier iteration.  (but I know he is a bit busy this week, including
>> a release tomorrow and several other things..)
> 
> It's starred in my mailbox.
> 

Hello Ben

Are you still busy?

-- 
Masaru Tsuchiyama <m....@gmail.com>

Re: [PATCH] add support for svnrdump to svn-backup-dumps.py

[Masaru Tsuchiyama <m....@gmail.com>]

I updated for head revision.

[[[
add support for svnrdump to svn-backup-dumps.py

* tools/server-side/svn-backup-dumps.py
   () : fix comment
   () : update to ver 0.7
   () : import urlparse
   (SvnBackup.__init__) : fix message in SvnBackupException constructor.
   (SvnBackup.__init__) : check whether the second parameter is a local
                          path or an URL.
   (SvnBackup.__init__) : check whether --deltas option is specified when
                          the second parameter is an URL.
   (SvnBackup.__init__) : set svn and svnrdump paths.
   (SvnBackup.__init__) : set flags for --trust-server-cert and
                          --no-auth-cache.
   (SvnBackup.exec_cmd_nt) : open null device and pass it to Popen
                             when printerr is False.
   (SvnBackup.get_extra_param) : get extra option for svn and svnrdump.
                                 always pass --non-interactive to
                                 svn and svnrdump to make sure.
   (SvnBackup.get_head_rev) : rename this to get_head_rev_for_local.
   (SvnBackup.get_head_rev_for_url) : get HEAD revision for an URL.
   (SvnBackup.get_head_rev) : call get_head_rev_for_local for a local
                              path, get_head_rev_for_url for an URL
   (SvnBackup.transfer_smb): pass self.__print_stderr to self.exec_cmd().

   (SvnBackup.create_dump) : invoke svnadmin for a local path,
                             svnrdump for an URL.
   (SvnBackup.create_dump) : pass "--" before self.__repospath.

   () : fix help message.
   () : add --svnrdump-path and --svn-path.
   () : add --trust-server-cert.
   () : add --no-auth-cache.
   () : add --non-interactive.
   () : add --print-stderr.
]]]

-- 
Masaru Tsuchiyama <m....@gmail.com>

Re: [PATCH] add support for svnrdump to svn-backup-dumps.py

[masaru tsuchiyama <m....@gmail.com>]

Hello

Could you review my patch?



2013-09-08 23:25 GMT+09:00 Masaru Tsuchiyama <m....@gmail.com>:

> Ben Reser wrote:
> > On 8/18/13 5:34 AM, Daniel Shahaf wrote:
> >> Haven't looked at the rest of the patch, perhaps Ben will as he reviewed
> >> an earlier iteration.  (but I know he is a bit busy this week, including
> >> a release tomorrow and several other things..)
> >
> > It's starred in my mailbox.
> >
>
> Hello Ben
>
> Are you still busy?
>
> --
> Masaru Tsuchiyama <m....@gmail.com>
>