You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2015/05/12 17:14:47 UTC
incubator-tinkerpop git commit: Remove a todo comment and include
resolution.
Repository: incubator-tinkerpop
Updated Branches:
refs/heads/master 365c77091 -> 582ccd365
Remove a todo comment and include resolution.
Project: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/commit/582ccd36
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/tree/582ccd36
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/diff/582ccd36
Branch: refs/heads/master
Commit: 582ccd365e11f95f5536ca336618fd4945e9bd28
Parents: 365c770
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Tue May 12 11:14:29 2015 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Tue May 12 11:14:29 2015 -0400
----------------------------------------------------------------------
.../main/java/org/apache/tinkerpop/gremlin/driver/Handler.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/582ccd36/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java
----------------------------------------------------------------------
diff --git a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java
index 5bc5b38..5489a61 100644
--- a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java
+++ b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java
@@ -66,11 +66,12 @@ class Handler {
pending.get(response.getRequestId()).markError(new ResponseException(response.getStatus().getCode(), response.getStatus().getMessage()));
}
- // todo: should this go in finally? where is the catch?
// as this is a non-PARTIAL_CONTENT code - the stream is done
if (response.getStatus().getCode() != ResponseStatusCode.PARTIAL_CONTENT)
pending.remove(response.getRequestId()).markComplete();
} finally {
+ // in the event of an exception above the exception is tossed and handled by whatever channelpipeline
+ // error handling is at play.
ReferenceCountUtil.release(response);
}
}