You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hudi.apache.org by hmantu <hm...@foxmail.com> on 2020/05/12 15:30:50 UTC

[DISCUSS] Why add unit tests for hudi-cli module

hi all, 



I can not understand why add so many tests for hudi-cli module? We know that each 
command has many options, unit tests can not cover all of these options, and each
module has thier own unit tests, so I think they are redundant, any thoughs?





Thanks

Re: [DISCUSS] Why add unit tests for hudi-cli module

Posted by hddong <ho...@gmail.com>.
This is mainly a function test, not a parameter test.
Also, ensure that all base commands are executed successfully.

Re: [DISCUSS] Why add unit tests for hudi-cli module

Posted by Vinoth Chandar <vi...@apache.org>.
+1
People rely on CLI to operate on Hudi datasets. So having some tests there,
would definitely be useful

On Tue, May 12, 2020 at 12:39 PM Shiyan Xu <xu...@gmail.com>
wrote:

> Hi, the tests in hudi-cli are more of functional tests. They are conducive
> to verifying features in cli module are working. Though not covering all
> options, it is always better to have some assuring passing tests than none,
> isn't it? :)
>
> On Tue, May 12, 2020 at 8:31 AM hmantu <hm...@foxmail.com> wrote:
>
> > hi all,
> >
> >
> >
> > I can not understand why add so many tests for hudi-cli module? We know
> > that each
> > command has many options, unit tests can not cover all of these options,
> > and each
> > module has thier own unit tests, so I think they are redundant, any
> > thoughs?
> >
> >
> >
> >
> >
> > Thanks
>

Re: [DISCUSS] Why add unit tests for hudi-cli module

Posted by Shiyan Xu <xu...@gmail.com>.
Hi, the tests in hudi-cli are more of functional tests. They are conducive
to verifying features in cli module are working. Though not covering all
options, it is always better to have some assuring passing tests than none,
isn't it? :)

On Tue, May 12, 2020 at 8:31 AM hmantu <hm...@foxmail.com> wrote:

> hi all,
>
>
>
> I can not understand why add so many tests for hudi-cli module? We know
> that each
> command has many options, unit tests can not cover all of these options,
> and each
> module has thier own unit tests, so I think they are redundant, any
> thoughs?
>
>
>
>
>
> Thanks