[GitHub] [incubator-pinot] npawar commented on pull request #5746: Fix code to correctly extract value of multi-value column from avro file

[GitBox <gi...@apache.org>]

npawar commented on pull request #5746:
URL: https://github.com/apache/incubator-pinot/pull/5746#issuecomment-663302060


   @jackjlli this doesn't look like the right fix for the issue. For GenericRecord, we should be looking at each field recursively.
   
   Also the AvroRecordExtractorComplexTypesTest will fail with this change.
   
   The code you're introducing makes an assumption that for a field of type GenericRecord in the avro raw data, we should always only look at the first fiel. That's not a good assumption right? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org