[GitHub] [trafficserver] maskit edited a comment on issue #8163: Over-eager HTTP/2 stream error rate threshold

[GitBox <gi...@apache.org>]

maskit edited a comment on issue #8163:
URL: https://github.com/apache/trafficserver/issues/8163#issuecomment-886503107


   I think this is due to lack of half-closed(local) state and also #5675.
   
   I agree on excluding common error cases from error rate calculation. However, #8166 looks fragile since it relies on existence of error message, and the error without a message in rcv_data_frame (i.e. receiving DATA on a non-open stream) may not be always safe to exclude because the function can be called on any stream state. If we receive a DATA frame before HEADERS, that is obviously an error which we should not exclude.
   
   I think we can exclude the error only if a stream is on half-closed (local) state. DATA frames may have been already on wire when ATS sends 504 response, and a RST_STREAM to tell a client not to send any more data on the sate is innocuous.
   
   After sending a RST_STREAM on half-closed(local) state, the stream state gets closed state. Then ATS should ignore frames for a while as described on #5675. If a client keeps sending frames to streams on closed state, that should be counted as an error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org