You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2018/04/02 18:26:44 UTC
[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9886
Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py
......................................................................
IMPALA-6780: Fix always-true asserts in test_recover_partitions.py
Fixes the following syntax issue leading to an always-true assert:
assert (cond, msg) <-- always true
Instead, this should be used:
assert cond, msg <-- cond and msg can optionally have parenthesis
Testing:
- Locally ran test_recover_partitions.py
- Searched for other tests with similar mistakes (none identified)
Change-Id: If38efa62c2496b69ae891bf916482d697bfc719f
---
M tests/metadata/test_recover_partitions.py
1 file changed, 23 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/9886/1
--
To view, visit http://gerrit.cloudera.org:8080/9886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If38efa62c2496b69ae891bf916482d697bfc719f
Gerrit-Change-Number: 9886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9886 )
Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2219/
--
To view, visit http://gerrit.cloudera.org:8080/9886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If38efa62c2496b69ae891bf916482d697bfc719f
Gerrit-Change-Number: 9886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 18:31:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9886 )
Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py
......................................................................
IMPALA-6780: Fix always-true asserts in test_recover_partitions.py
Fixes the following syntax issue leading to an always-true assert:
assert (cond, msg) <-- always true
Instead, this should be used:
assert cond, msg <-- cond and msg can optionally have parenthesis
Testing:
- Locally ran test_recover_partitions.py
- Searched for other tests with similar mistakes (none identified)
Change-Id: If38efa62c2496b69ae891bf916482d697bfc719f
Reviewed-on: http://gerrit.cloudera.org:8080/9886
Tested-by: Impala Public Jenkins
Reviewed-by: Alex Behm <al...@cloudera.com>
---
M tests/metadata/test_recover_partitions.py
1 file changed, 23 insertions(+), 23 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If38efa62c2496b69ae891bf916482d697bfc719f
Gerrit-Change-Number: 9886
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9886 )
Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2219/
--
To view, visit http://gerrit.cloudera.org:8080/9886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If38efa62c2496b69ae891bf916482d697bfc719f
Gerrit-Change-Number: 9886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 22:26:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9886 )
Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py
......................................................................
Patch Set 1:
Very odd failures that look unrelated. Will take a look.
--
To view, visit http://gerrit.cloudera.org:8080/9886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If38efa62c2496b69ae891bf916482d697bfc719f
Gerrit-Change-Number: 9886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 23:41:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9886 )
Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If38efa62c2496b69ae891bf916482d697bfc719f
Gerrit-Change-Number: 9886
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 18:28:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9886 )
Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If38efa62c2496b69ae891bf916482d697bfc719f
Gerrit-Change-Number: 9886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 08:05:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9886 )
Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2226/
--
To view, visit http://gerrit.cloudera.org:8080/9886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If38efa62c2496b69ae891bf916482d697bfc719f
Gerrit-Change-Number: 9886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 00:59:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6780: Fix always-true asserts in test recover partitions.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9886 )
Change subject: IMPALA-6780: Fix always-true asserts in test_recover_partitions.py
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If38efa62c2496b69ae891bf916482d697bfc719f
Gerrit-Change-Number: 9886
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 04:44:21 +0000
Gerrit-HasComments: No