You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/09 15:53:31 UTC

[GitHub] [iceberg] shardulm94 commented on a change in pull request #1569: API: add some validation when create bucket/truncate partition

shardulm94 commented on a change in pull request #1569:
URL: https://github.com/apache/iceberg/pull/1569#discussion_r502524356



##########
File path: api/src/test/java/org/apache/iceberg/transforms/TestTruncate.java
##########
@@ -86,4 +87,12 @@ public void testTruncateByteBuffer() throws Exception {
         ByteBuffer.wrap("abc".getBytes("UTF-8")),
         trunc.apply(ByteBuffer.wrap("abc".getBytes("UTF-8"))));
   }
+
+  @Test
+  public void testVerifiedIllegalWidth() {
+    AssertHelpers.assertThrows("Should fail if width is less than or equal to zero",
+        IllegalArgumentException.class,
+        "The width of truncate must larger than zero",

Review comment:
       `must larger` -> `must be larger`, here and in other places with similar message




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org