[jira] [Commented] (IMPALA-8147) Merge make_impala.sh into CMake and buildall.sh

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787370#comment-16787370 ] 

ASF subversion and git services commented on IMPALA-8147:
---------------------------------------------------------

Commit 6b0fd9fa8023c9c06b2bce2811097df29827731a in impala's branch refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6b0fd9f ]

IMPALA-8147: part 2: Remove make_impala.sh

The previous commit rendered this scripts unused from within
the Impala repository. This removes make_impala.sh and
related scripts entirely.

Testing:
Did a trial run with the -debug_and_release flag to make sure that it
could build all artifacts as expected.

Change-Id: I8688ef9fe651475907cb319eb0b336fd6bef8dfe
Reviewed-on: http://gerrit.cloudera.org:8080/12556
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Merge make_impala.sh into CMake and buildall.sh
> -----------------------------------------------
>
>                 Key: IMPALA-8147
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8147
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>
> make_impala.sh seems to be an unnecessary layer in the build system between buildall.sh and the CMake scripts. Per discussion on dev@, I think we should:
> * Move any logic required for doing incremental builds into CMakeLists. E.g. gen_build_version.py
> * *maybe* consider moving the CMake invocation logic into a separate script that does one clear-cut thing
> * Move the make invocation logic into a function in buildall.sh
> * Add support to buildall.sh to build both the debug and release binaries.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org